Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2676823002: Add option --compile-sdk to fasta compile and run. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index bd93c117b14273682a1d0cde3828a868deda3517..80f04f4eaf2aed174d18edd4f09496f100b57521 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -207,7 +207,7 @@ class KernelSourceTarget extends TargetImplementation {
print(message);
errors.add(message);
}
- program = erroneousProgram();
+ program = erroneousProgram(isFullProgram);
return uri == null
? new Future<Program>.value(program)
: writeLinkedProgram(uri, program, isFullProgram: isFullProgram);
@@ -265,15 +265,17 @@ class KernelSourceTarget extends TargetImplementation {
}
}
- Program erroneousProgram() {
+ Program erroneousProgram(bool isFullProgram) {
Uri uri = loader.first?.uri ?? Uri.parse("error:error");
KernelLibraryBuilder library = new KernelLibraryBuilder(uri, loader);
- KernelProcedureBuilder mainBuilder = new KernelProcedureBuilder(null, 0,
- null, "main", null, null, AsyncMarker.Sync, ProcedureKind.Method);
- library.addBuilder(mainBuilder.name, mainBuilder);
loader.first = library;
- mainBuilder.body = new ExpressionStatement(
- new Throw(new StringLiteral("${errors.join('\n')}")));
+ if (isFullProgram) {
ahe 2017/02/03 14:37:12 If we're generated an outline, we shouldn't add an
Siggi Cherem (dart-lang) 2017/02/03 18:16:57 makes sense - same thing in the future when genera
ahe 2017/02/03 19:34:14 Good point. I should turn this into a comment. Als
ahe 2017/02/03 20:03:36 Done.
+ KernelProcedureBuilder mainBuilder = new KernelProcedureBuilder(null, 0,
+ null, "main", null, null, AsyncMarker.Sync, ProcedureKind.Method);
+ library.addBuilder(mainBuilder.name, mainBuilder);
+ mainBuilder.body = new ExpressionStatement(
+ new Throw(new StringLiteral("${errors.join('\n')}")));
+ }
library.build();
return link(<Library>[library.library]);
}

Powered by Google App Engine
This is Rietveld 408576698