Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2676773002: DevTools: restore the style of expandable titles on console object previews (Closed)
Patch Set: a Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 if (includePreview && obj.preview) { 531 if (includePreview && obj.preview) {
532 titleElement.classList.add('console-object-preview'); 532 titleElement.classList.add('console-object-preview');
533 this._previewFormatter.appendObjectPreview(titleElement, obj.preview, fals e /* isEntry */); 533 this._previewFormatter.appendObjectPreview(titleElement, obj.preview, fals e /* isEntry */);
534 } else if (obj.type === 'function') { 534 } else if (obj.type === 'function') {
535 Components.ObjectPropertiesSection.formatObjectAsFunction(obj, titleElemen t, false); 535 Components.ObjectPropertiesSection.formatObjectAsFunction(obj, titleElemen t, false);
536 titleElement.classList.add('object-value-function'); 536 titleElement.classList.add('object-value-function');
537 } else { 537 } else {
538 titleElement.createTextChild(obj.description || ''); 538 titleElement.createTextChild(obj.description || '');
539 } 539 }
540 540
541 var note = titleElement.createChild('span', 'object-state-note');
542 note.classList.add('info-note');
543 note.title = Common.UIString('Value below was evaluated just now.');
544
541 var section = new Components.ObjectPropertiesSection(obj, titleElement, this ._linkifier); 545 var section = new Components.ObjectPropertiesSection(obj, titleElement, this ._linkifier);
542 section.element.classList.add('console-view-object-properties-section'); 546 section.element.classList.add('console-view-object-properties-section');
543 section.enableContextMenu(); 547 section.enableContextMenu();
544 return section.element; 548 return section.element;
545 } 549 }
546 550
547 /** 551 /**
548 * @param {!SDK.RemoteObject} func 552 * @param {!SDK.RemoteObject} func
549 * @param {boolean=} includePreview 553 * @param {boolean=} includePreview
550 * @return {!Element} 554 * @return {!Element}
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1256 toMessageElement() { 1260 toMessageElement() {
1257 if (!this._element) { 1261 if (!this._element) {
1258 super.toMessageElement(); 1262 super.toMessageElement();
1259 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon'); 1263 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
1260 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild); 1264 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild);
1261 this.setCollapsed(this._collapsed); 1265 this.setCollapsed(this._collapsed);
1262 } 1266 }
1263 return this._element; 1267 return this._element;
1264 } 1268 }
1265 }; 1269 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698