Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2676633003: Add server-side communications channel (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -9 lines) Patch
M pkg/analyzer_plugin/lib/channel/channel.dart View 2 chunks +33 lines, -2 lines 2 comments Download
M pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart View 3 chunks +82 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/test/src/channel/isolate_channel_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-02 18:20:19 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2676633003/diff/1/pkg/analyzer_plugin/lib/channel/channel.dart File pkg/analyzer_plugin/lib/channel/channel.dart (right): https://codereview.chromium.org/2676633003/diff/1/pkg/analyzer_plugin/lib/channel/channel.dart#newcode58 pkg/analyzer_plugin/lib/channel/channel.dart:58: * socket is closed by the client, invoke ...
3 years, 10 months ago (2017-02-02 18:25:04 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2676633003/diff/1/pkg/analyzer_plugin/lib/channel/channel.dart File pkg/analyzer_plugin/lib/channel/channel.dart (right): https://codereview.chromium.org/2676633003/diff/1/pkg/analyzer_plugin/lib/channel/channel.dart#newcode58 pkg/analyzer_plugin/lib/channel/channel.dart:58: * socket is closed by the client, invoke the ...
3 years, 10 months ago (2017-02-02 18:46:39 UTC) #4
Brian Wilkerson
3 years, 10 months ago (2017-02-02 18:47:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b22f453a87e83e87a26ae3a7631ed3bfe1f0bfc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698