Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2676593006: Initial support for managing partial results from plugins (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initial support for managing partial results from plugins R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a8f65e61a9ea885f76479ebd2b1b3a586c39cc89

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -9 lines) Patch
A pkg/analysis_server/lib/src/plugin/result_collector.dart View 1 chunk +96 lines, -0 lines 2 comments Download
A pkg/analysis_server/test/src/plugin/result_collector_test.dart View 1 chunk +110 lines, -0 lines 0 comments Download
A + pkg/analysis_server/test/src/plugin/test_all.dart View 1 chunk +4 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/src/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-03 22:18:41 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2676593006/diff/1/pkg/analysis_server/lib/src/plugin/result_collector.dart File pkg/analysis_server/lib/src/plugin/result_collector.dart (right): https://codereview.chromium.org/2676593006/diff/1/pkg/analysis_server/lib/src/plugin/result_collector.dart#newcode50 pkg/analysis_server/lib/src/plugin/result_collector.dart:50: * for the given [filePath], Did you want ...
3 years, 10 months ago (2017-02-04 03:05:16 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2676593006/diff/1/pkg/analysis_server/lib/src/plugin/result_collector.dart File pkg/analysis_server/lib/src/plugin/result_collector.dart (right): https://codereview.chromium.org/2676593006/diff/1/pkg/analysis_server/lib/src/plugin/result_collector.dart#newcode50 pkg/analysis_server/lib/src/plugin/result_collector.dart:50: * for the given [filePath], No, just mistyped.
3 years, 10 months ago (2017-02-04 17:45:38 UTC) #4
Brian Wilkerson
3 years, 10 months ago (2017-02-04 17:46:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a8f65e61a9ea885f76479ebd2b1b3a586c39cc89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698