Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: src/objects-printer.cc

Issue 2676583002: [ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags. (Closed)
Patch Set: Rebasing Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-printer.cc
diff --git a/src/objects-printer.cc b/src/objects-printer.cc
index 903785f96c8b89f16b6da8280bcdbd046bbe22cb..595728f1bfb2516ba0364e41a3e3dca29293cb1e 100644
--- a/src/objects-printer.cc
+++ b/src/objects-printer.cc
@@ -697,7 +697,7 @@ void FeedbackVectorSpecBase<Derived>::FeedbackVectorSpecPrint(
}
for (int slot = 0; slot < slot_count;) {
- FeedbackVectorSlotKind kind = This()->GetKind(slot);
+ FeedbackVectorSlotKind kind = This()->GetKind(FeedbackVectorSlot(slot));
int entry_size = TypeFeedbackMetadata::GetSlotSize(kind);
DCHECK_LT(0, entry_size);
os << "\n Slot #" << slot << " " << kind;
@@ -776,12 +776,14 @@ void TypeFeedbackVector::TypeFeedbackVectorPrint(std::ostream& os) { // NOLINT
os << Code::ICState2String(nexus.StateFromFeedback());
break;
}
- case FeedbackVectorSlotKind::STORE_IC: {
+ case FeedbackVectorSlotKind::STORE_SLOPPY_IC:
+ case FeedbackVectorSlotKind::STORE_STRICT_IC: {
StoreICNexus nexus(this, slot);
os << Code::ICState2String(nexus.StateFromFeedback());
break;
}
- case FeedbackVectorSlotKind::KEYED_STORE_IC: {
+ case FeedbackVectorSlotKind::KEYED_STORE_SLOPPY_IC:
+ case FeedbackVectorSlotKind::KEYED_STORE_STRICT_IC: {
KeyedStoreICNexus nexus(this, slot);
os << Code::ICState2String(nexus.StateFromFeedback());
break;

Powered by Google App Engine
This is Rietveld 408576698