Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: src/heap/heap.cc

Issue 2676583002: [ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags. (Closed)
Patch Set: Rebasing Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 6a5456240053e864e94f8a313376d2261272b8a6..dbb09aa45e8db14401959ccf0ee8f5515d9ee668 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -2759,17 +2759,7 @@ void Heap::CreateInitialObjects() {
StaticFeedbackVectorSpec spec;
FeedbackVectorSlot slot = spec.AddLoadICSlot();
DCHECK_EQ(slot, FeedbackVectorSlot(TypeFeedbackVector::kDummyLoadICSlot));
-
- slot = spec.AddKeyedLoadICSlot();
- DCHECK_EQ(slot,
- FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot));
-
- slot = spec.AddStoreICSlot();
- DCHECK_EQ(slot, FeedbackVectorSlot(TypeFeedbackVector::kDummyStoreICSlot));
-
- slot = spec.AddKeyedStoreICSlot();
- DCHECK_EQ(slot,
- FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
+ USE(slot);
Handle<TypeFeedbackMetadata> dummy_metadata =
TypeFeedbackMetadata::New(isolate(), &spec);
@@ -2780,9 +2770,6 @@ void Heap::CreateInitialObjects() {
// Now initialize dummy vector's entries.
LoadICNexus(isolate()).ConfigureMegamorphic();
- StoreICNexus(isolate()).ConfigureMegamorphic();
- KeyedLoadICNexus(isolate()).ConfigureMegamorphicKeyed(PROPERTY);
- KeyedStoreICNexus(isolate()).ConfigureMegamorphicKeyed(PROPERTY);
}
{

Powered by Google App Engine
This is Rietveld 408576698