Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: src/compiler/js-native-context-specialization.cc

Issue 2676583002: [ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags. (Closed)
Patch Set: Rebasing Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-native-context-specialization.h" 5 #include "src/compiler/js-native-context-specialization.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/compilation-dependencies.h" 9 #include "src/compilation-dependencies.h"
10 #include "src/compiler/access-builder.h" 10 #include "src/compiler/access-builder.h"
(...skipping 1529 matching lines...) Expand 10 before | Expand all | Expand 10 after
1540 value, effect, control); 1540 value, effect, control);
1541 if (access_info.HasTransitionMap()) { 1541 if (access_info.HasTransitionMap()) {
1542 effect = graph()->NewNode(common()->FinishRegion(), 1542 effect = graph()->NewNode(common()->FinishRegion(),
1543 jsgraph()->UndefinedConstant(), effect); 1543 jsgraph()->UndefinedConstant(), effect);
1544 } 1544 }
1545 } 1545 }
1546 } else { 1546 } else {
1547 DCHECK(access_info.IsGeneric()); 1547 DCHECK(access_info.IsGeneric());
1548 DCHECK_EQ(AccessMode::kStore, access_mode); 1548 DCHECK_EQ(AccessMode::kStore, access_mode);
1549 DCHECK(vector->IsStoreIC(slot)); 1549 DCHECK(vector->IsStoreIC(slot));
1550 DCHECK_EQ(vector->GetLanguageMode(slot), language_mode);
1550 Callable callable = 1551 Callable callable =
1551 CodeFactory::StoreICInOptimizedCode(isolate(), language_mode); 1552 CodeFactory::StoreICInOptimizedCode(isolate(), language_mode);
1552 const CallInterfaceDescriptor& descriptor = callable.descriptor(); 1553 const CallInterfaceDescriptor& descriptor = callable.descriptor();
1553 CallDescriptor* desc = Linkage::GetStubCallDescriptor( 1554 CallDescriptor* desc = Linkage::GetStubCallDescriptor(
1554 isolate(), graph()->zone(), descriptor, 1555 isolate(), graph()->zone(), descriptor,
1555 descriptor.GetStackParameterCount(), CallDescriptor::kNeedsFrameState, 1556 descriptor.GetStackParameterCount(), CallDescriptor::kNeedsFrameState,
1556 Operator::kNoProperties); 1557 Operator::kNoProperties);
1557 Node* stub_code = jsgraph()->HeapConstant(callable.code()); 1558 Node* stub_code = jsgraph()->HeapConstant(callable.code());
1558 Node* name_node = jsgraph()->HeapConstant(name); 1559 Node* name_node = jsgraph()->HeapConstant(name);
1559 Node* slot_node = jsgraph()->Constant(vector->GetIndex(slot)); 1560 Node* slot_node = jsgraph()->Constant(vector->GetIndex(slot));
(...skipping 686 matching lines...) Expand 10 before | Expand all | Expand 10 after
2246 return jsgraph()->javascript(); 2247 return jsgraph()->javascript();
2247 } 2248 }
2248 2249
2249 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const { 2250 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const {
2250 return jsgraph()->simplified(); 2251 return jsgraph()->simplified();
2251 } 2252 }
2252 2253
2253 } // namespace compiler 2254 } // namespace compiler
2254 } // namespace internal 2255 } // namespace internal
2255 } // namespace v8 2256 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698