third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc - Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)

Patch Set: address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h ('k') | third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

index d3503ca885225cf3a977c83874ddde7734a9e675..9371806edc8a782c5a5d7df1c562d06a4aa5b845 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

@@ -25,7 +25,7 @@ NGTextLayoutAlgorithm::NGTextLayoutAlgorithm(

DCHECK(inline_box_);

}

-NGPhysicalFragment* NGTextLayoutAlgorithm::Layout() {

+RefPtr<NGPhysicalFragment> NGTextLayoutAlgorithm::Layout() {

ASSERT_NOT_REACHED();

return nullptr;

}