Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)
Patch Set: address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
index eaf9f8cf810758c5d7de35fdc4dffca2328b4d90..53269660274eee2a0ae9698f356ab2e2e2bc831e 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
@@ -23,16 +23,17 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
LayoutObject* layout_object,
NGPhysicalSize size,
NGPhysicalSize overflow,
- HeapVector<Member<NGPhysicalFragment>>& children,
- HeapLinkedHashSet<WeakMember<NGBlockNode>>& out_of_flow_descendants,
+ Vector<RefPtr<NGPhysicalFragment>>& children,
+ PersistentHeapLinkedHashSet<WeakMember<NGBlockNode>>&
+ out_of_flow_descendants,
Vector<NGStaticPosition>& out_of_flow_positions,
- HeapVector<Member<NGFloatingObject>>& unpositioned_floats,
- HeapVector<Member<NGFloatingObject>>& positioned_floats,
+ Vector<Persistent<NGFloatingObject>>& unpositioned_floats,
+ Vector<Persistent<NGFloatingObject>>& positioned_floats,
const WTF::Optional<NGLogicalOffset>& bfc_offset,
const NGMarginStrut& end_margin_strut,
NGBreakToken* break_token = nullptr);
- const HeapVector<Member<NGPhysicalFragment>>& Children() const {
+ const Vector<RefPtr<NGPhysicalFragment>>& Children() const {
return children_;
}
@@ -42,16 +43,12 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
const NGMarginStrut& EndMarginStrut() const { return end_margin_strut_; }
- DECLARE_TRACE_AFTER_DISPATCH();
-
private:
- HeapVector<Member<NGPhysicalFragment>> children_;
+ Vector<RefPtr<NGPhysicalFragment>> children_;
const WTF::Optional<NGLogicalOffset> bfc_offset_;
const NGMarginStrut end_margin_strut_;
};
-WILL_NOT_BE_EAGERLY_TRACED_CLASS(NGPhysicalBoxFragment);
-
DEFINE_TYPE_CASTS(NGPhysicalBoxFragment,
NGPhysicalFragment,
fragment,

Powered by Google App Engine
This is Rietveld 408576698