Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)
Patch Set: address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h
index fcf647537e5fd03b41b74ec3e7c21ef66150b5d0..daf91ef2a6c13c36c211dadb219a42606b7e806f 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h
@@ -18,7 +18,6 @@ namespace blink {
class ComputedStyle;
class NGBlockNode;
-class NGFragment;
class NGFragmentBuilder;
class NGConstraintSpace;
@@ -35,16 +34,17 @@ class CORE_EXPORT NGOutOfFlowLayoutPart {
void Run();
private:
- NGFragment* LayoutDescendant(NGBlockNode& descendant,
- NGStaticPosition static_position,
- NGLogicalOffset* offset);
+ RefPtr<NGPhysicalFragment> LayoutDescendant(NGBlockNode& descendant,
+ NGStaticPosition static_position,
+ NGLogicalOffset* offset);
- NGFragment* GenerateFragment(NGBlockNode& node,
- const Optional<LayoutUnit>& block_estimate,
- const NGAbsolutePhysicalPosition node_position);
+ RefPtr<NGPhysicalFragment> GenerateFragment(
+ NGBlockNode& node,
+ const Optional<LayoutUnit>& block_estimate,
+ const NGAbsolutePhysicalPosition node_position);
const ComputedStyle& container_style_;
- Member<NGFragmentBuilder> container_builder_;
+ NGFragmentBuilder* container_builder_;
NGLogicalOffset container_border_offset_;
NGPhysicalOffset container_border_physical_offset_;

Powered by Google App Engine
This is Rietveld 408576698