Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)
Patch Set: address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
index 5a58fe51f1ed8a896660ef9e4893f309bb484d34..a5d8832c698c644f75b983a07f57ff5505171890 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
@@ -7,6 +7,7 @@
#include "core/CoreExport.h"
#include "core/layout/ng/ng_break_token.h"
+#include "core/layout/ng/ng_fragment_builder.h"
#include "core/layout/ng/ng_layout_algorithm.h"
#include "platform/heap/Handle.h"
#include "wtf/RefPtr.h"
@@ -16,7 +17,6 @@ namespace blink {
class ComputedStyle;
class LayoutObject;
class NGConstraintSpace;
-class NGFragmentBuilder;
class NGInlineNode;
// A class for inline layout (e.g. a anonymous block with inline-level children
@@ -40,7 +40,7 @@ class CORE_EXPORT NGInlineLayoutAlgorithm : public NGLayoutAlgorithm {
NGConstraintSpace* space,
NGBreakToken* break_token = nullptr);
- NGPhysicalFragment* Layout() override;
+ RefPtr<NGPhysicalFragment> Layout() override;
private:
// Read-only Getters.
@@ -52,7 +52,7 @@ class CORE_EXPORT NGInlineLayoutAlgorithm : public NGLayoutAlgorithm {
Persistent<NGInlineNode> first_child_;
Persistent<NGConstraintSpace> constraint_space_;
Persistent<NGBreakToken> break_token_;
- Persistent<NGFragmentBuilder> builder_;
+ std::unique_ptr<NGFragmentBuilder> builder_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698