third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h - Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)

Patch Set: address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h

index 6695b352092e41e471adfe1f8baf2e68e27eec1a..ceb5c06fe5ccf1c7cfeb52765067aa938b4e359e 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h

@@ -16,9 +16,8 @@ namespace blink {

class CORE_EXPORT NGBoxFragment final : public NGFragment {

public:

NGBoxFragment(NGWritingMode writing_mode,

- TextDirection direction,

NGPhysicalBoxFragment* physical_fragment)

- : NGFragment(writing_mode, direction, physical_fragment) {}

+ : NGFragment(writing_mode, physical_fragment) {}

const WTF::Optional<NGLogicalOffset>& BfcOffset() const;