Adds HotwordPrivate API for integrating the hotword feature to AppLauncher

Adds HotwordPrivate API for integrating the hotword feature to AppLauncher

BUG=361662
TEST=manually
R=asargent@chromium.org, asvitkine@chromium.org, rlp@chromium.org, xiyuan@chromium.org
TBR=asvitkine@chromium.org, jered@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269107

[rpetterson, 2014-05-02 19:13:15]

Adding Antony who is most familiar with our hotwordPrivate api as an extensions/
reviewer.

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
File chrome/browser/search/hotword_service.cc (right):

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
chrome/browser/search/hotword_service.cc:283: HotwordClient* client) {
move to line above

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
chrome/browser/search/hotword_service.cc:287: if (client_)
combine with the line above:
if (!IsServiceAvailable || client_)
  return;

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
chrome/browser/search/hotword_service.cc:299: HotwordClient* client) {
move to line above

https://codereview.chromium.org/267653005/diff/100001/chrome/common/extension...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/267653005/diff/100001/chrome/common/extension...
chrome/common/extensions/api/hotword_private.idl:51: // Sets the current hotword
session state for the browser's special request.
What does the "browser's special request" mean?

https://codereview.chromium.org/267653005/diff/100001/chrome/common/extension...
chrome/common/extensions/api/hotword_private.idl:55: // Notifies the hotword is
recognized for the browser-requested hotword
If I'm understanding correctly, this function is used to pass along the fact
that a hotword ("ok google," etc.) was recognized by the nacl component and we
want to pass that information along to Chrome. Perhaps reword:
// Notifies that a hotword has been recognized in the browser-requested hotword
session.

[Jun Mukai, 2014-05-02 22:18:57]

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
File chrome/browser/search/hotword_service.cc (right):

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
chrome/browser/search/hotword_service.cc:283: HotwordClient* client) {
On 2014/05/02 19:13:16, rpetterson wrote:
> move to line above

Done.

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
chrome/browser/search/hotword_service.cc:287: if (client_)
On 2014/05/02 19:13:16, rpetterson wrote:
> combine with the line above:
> if (!IsServiceAvailable || client_)
>   return;

Done.

https://codereview.chromium.org/267653005/diff/100001/chrome/browser/search/h...
chrome/browser/search/hotword_service.cc:299: HotwordClient* client) {
On 2014/05/02 19:13:16, rpetterson wrote:
> move to line above

Done.

https://codereview.chromium.org/267653005/diff/100001/chrome/common/extension...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/267653005/diff/100001/chrome/common/extension...
chrome/common/extensions/api/hotword_private.idl:51: // Sets the current hotword
session state for the browser's special request.
On 2014/05/02 19:13:16, rpetterson wrote:
> What does the "browser's special request" mean?

that is browser-requested hotword session. updated the comment.

https://codereview.chromium.org/267653005/diff/100001/chrome/common/extension...
chrome/common/extensions/api/hotword_private.idl:55: // Notifies the hotword is
recognized for the browser-requested hotword
On 2014/05/02 19:13:16, rpetterson wrote:
> If I'm understanding correctly, this function is used to pass along the fact
> that a hotword ("ok google," etc.) was recognized by the nacl component and we
> want to pass that information along to Chrome. Perhaps reword:
> // Notifies that a hotword has been recognized in the browser-requested
hotword
> session.
> 

Done.

[xiyuan, 2014-05-02 22:21:08]

app_list/* LGTM

[asargent_no_longer_on_chrome, 2014-05-04 21:55:23]

lgtm

https://codereview.chromium.org/267653005/diff/70016/chrome/common/extensions...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/267653005/diff/70016/chrome/common/extensions...
chrome/common/extensions/api/hotword_private.idl:52: static void
setHotwordSessionState(boolean started, optional GenericDoneCallback callback);
nit: > 80 chars - wrap at the "," like a c++ function

https://codereview.chromium.org/267653005/diff/70016/chrome/common/extensions...
chrome/common/extensions/api/hotword_private.idl:56: static void
notifyHotwordRecognition(HotwordType type, optional GenericDoneCallback
callback);
same nit here

[Jun Mukai, 2014-05-05 18:45:03]

https://codereview.chromium.org/267653005/diff/70016/chrome/common/extensions...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/267653005/diff/70016/chrome/common/extensions...
chrome/common/extensions/api/hotword_private.idl:52: static void
setHotwordSessionState(boolean started, optional GenericDoneCallback callback);
On 2014/05/04 21:55:23, Antony Sargent wrote:
> nit: > 80 chars - wrap at the "," like a c++ function

Done.

https://codereview.chromium.org/267653005/diff/70016/chrome/common/extensions...
chrome/common/extensions/api/hotword_private.idl:56: static void
notifyHotwordRecognition(HotwordType type, optional GenericDoneCallback
callback);
On 2014/05/04 21:55:23, Antony Sargent wrote:
> same nit here

Done.

[rpetterson, 2014-05-05 19:43:35]

https://codereview.chromium.org/267653005/diff/120001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_list_view_delegate.cc (right):

https://codereview.chromium.org/267653005/diff/120001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_list_view_delegate.cc:155: if
(speech_ui_->state() == app_list::SPEECH_RECOGNITION_HOTWORD_LISTENING)
I'm confused by what the "enabled" parameter is referring to. Does it refer to
whether hotwording is enabled? However, you pass "params->started" to the call
in hotword_private_api.cc. How are started and enabled related?

[Jun Mukai, 2014-05-05 20:00:54]

https://codereview.chromium.org/267653005/diff/120001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_list_view_delegate.cc (right):

https://codereview.chromium.org/267653005/diff/120001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_list_view_delegate.cc:155: if
(speech_ui_->state() == app_list::SPEECH_RECOGNITION_HOTWORD_LISTENING)
On 2014/05/05 19:43:36, rpetterson wrote:
> I'm confused by what the "enabled" parameter is referring to. Does it refer to
> whether hotwording is enabled? However, you pass "params->started" to the call
> in hotword_private_api.cc. How are started and enabled related?

good catch. changed to use 'started' everywhere

[rpetterson, 2014-05-05 20:08:43]

On 2014/05/05 20:00:54, Jun Mukai wrote:
>
https://codereview.chromium.org/267653005/diff/120001/chrome/browser/ui/app_l...
> File chrome/browser/ui/app_list/app_list_view_delegate.cc (right):
> 
>
https://codereview.chromium.org/267653005/diff/120001/chrome/browser/ui/app_l...
> chrome/browser/ui/app_list/app_list_view_delegate.cc:155: if
> (speech_ui_->state() == app_list::SPEECH_RECOGNITION_HOTWORD_LISTENING)
> On 2014/05/05 19:43:36, rpetterson wrote:
> > I'm confused by what the "enabled" parameter is referring to. Does it refer
to
> > whether hotwording is enabled? However, you pass "params->started" to the
call
> > in hotword_private_api.cc. How are started and enabled related?
> 
> good catch. changed to use 'started' everywhere

Cool. Makes more sense now.

LGTM

[Jun Mukai, 2014-05-05 21:25:17]

Setting TBR=asvitkine (for histgrams, trivial automatic changes) and jered (for
chrome/browser/search, already got lgtm from rlp@)

[Jun Mukai, 2014-05-05 21:25:23]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-05 21:26:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/267653005/140001

[commit-bot: I haz the power, 2014-05-06 00:36:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium
  linux_chromium_clang_dbg on tryserver.chromium
  mac_chromium_compile_dbg on tryserver.chromium
  mac_chromium_rel on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[Jun Mukai, 2014-05-06 00:55:38]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-06 00:55:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/267653005/160001

[commit-bot: I haz the power, 2014-05-06 04:55:33]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium

[commit-bot: I haz the power, 2014-05-06 05:17:52]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium

[commit-bot: I haz the power, 2014-05-06 05:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-06 05:33:05]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium

[Alexei Svitkine (slow), 2014-05-06 13:30:35]

lgtm for histograms

[Jun Mukai, 2014-05-06 18:08:54]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-06 18:09:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/267653005/180001

[Jun Mukai, 2014-05-06 20:50:53]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-06 20:53:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/267653005/200001

[Jun Mukai, 2014-05-06 21:40:45]

The CQ bit was unchecked by mukai@chromium.org

[Jun Mukai, 2014-05-06 21:46:51]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-06 21:49:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/267653005/220001

[Jun Mukai, 2014-05-06 22:14:54]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-06 22:15:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/267653005/240001

[commit-bot: I haz the power, 2014-05-07 15:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-07 15:18:27]

Failed to apply patch for
extensions/browser/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/browser/extension_function_histogram_value.h
  Hunk #1 FAILED at 812.
  1 out of 1 hunk FAILED -- saving rejects to file
extensions/browser/extension_function_histogram_value.h.rej

Patch:       extensions/browser/extension_function_histogram_value.h
Index: extensions/browser/extension_function_histogram_value.h
diff --git a/extensions/browser/extension_function_histogram_value.h
b/extensions/browser/extension_function_histogram_value.h
index
8cac2aa9faaa057d249926274b6c367284b49c10..2408091690a960daa5d8668dab1113caa92e52b6
100644
--- a/extensions/browser/extension_function_histogram_value.h
+++ b/extensions/browser/extension_function_histogram_value.h
@@ -812,6 +812,8 @@ enum HistogramValue {
   FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDERROR,
   BROWSER_OPENTAB,
   MANAGEMENT_CREATEAPPSHORTCUT,
+  HOTWORDPRIVATE_SETHOTWORDSESSIONSTATE,
+  HOTWORDPRIVATE_NOTIFYHOTWORDRECOGNITION,
   // Last entry: Add new entries above and ensure to update
   // tools/metrics/histograms/histograms/histograms.xml.
   ENUM_BOUNDARY

[Jun Mukai, 2014-05-07 16:44:08]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-07 16:48:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/267653005/260001

[commit-bot: I haz the power, 2014-05-08 02:32:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
  win_chromium_compile_dbg on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 03:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 03:51:52]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium

[Jun Mukai, 2014-05-08 23:52:26]

Committed patchset #16 manually as r269107 (presubmit successful).