Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 267653004: Improve about:sync output for enhanced_bookmarks experiment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/proto_value_conversions.cc
diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc
index 4fb8bddf04bea642d56df64c6a641663434b1574..c261da9753bbc9aa7d62a99fe4075c4e710e6eab 100644
--- a/sync/protocol/proto_value_conversions.cc
+++ b/sync/protocol/proto_value_conversions.cc
@@ -508,6 +508,14 @@ base::DictionaryValue* FaviconSyncFlagsToValue(
return value;
}
+base::DictionaryValue* EnhancedBookmarksFlagsToValue(
+ const sync_pb::EnhancedBookmarksFlags& proto) {
+ base::DictionaryValue* value = new base::DictionaryValue();
+ SET_BOOL(enabled);
+ SET_STR(extension_id);
+ return value;
+}
+
} // namespace
base::DictionaryValue* ExperimentsSpecificsToValue(
@@ -519,7 +527,7 @@ base::DictionaryValue* ExperimentsSpecificsToValue(
SET_EXPERIMENT_ENABLED_FIELD(pre_commit_update_avoidance);
SET(favicon_sync, FaviconSyncFlagsToValue);
SET_EXPERIMENT_ENABLED_FIELD(gcm_channel);
- SET_EXPERIMENT_ENABLED_FIELD(enhanced_bookmarks);
+ SET(enhanced_bookmarks, EnhancedBookmarksFlagsToValue);
SET_EXPERIMENT_ENABLED_FIELD(gcm_invalidations);
return value;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698