Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 2676513007: Do not show Scan or Sign In options when credit card form is non-secure (Closed)
Patch Set: Add unit tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 CardUploadDecisionMetric* 417 CardUploadDecisionMetric*
418 address_upload_decision_metric, 418 address_upload_decision_metric,
419 std::string* rappor_metric_name) const; 419 std::string* rappor_metric_name) const;
420 420
421 // If |initial_interaction_timestamp_| is unset or is set to a later time than 421 // If |initial_interaction_timestamp_| is unset or is set to a later time than
422 // |interaction_timestamp|, updates the cached timestamp. The latter check is 422 // |interaction_timestamp|, updates the cached timestamp. The latter check is
423 // needed because IPC messages can arrive out of order. 423 // needed because IPC messages can arrive out of order.
424 void UpdateInitialInteractionTimestamp( 424 void UpdateInitialInteractionTimestamp(
425 const base::TimeTicks& interaction_timestamp); 425 const base::TimeTicks& interaction_timestamp);
426 426
427 // Examines |form| and returns true if it is in a non-secure context or
428 // its action attribute targets a HTTP url.
429 bool IsFormNonSecure(const FormData& form) const;
430
427 // Uses the existing personal data in |profiles| and |credit_cards| to 431 // Uses the existing personal data in |profiles| and |credit_cards| to
428 // determine possible field types for the |submitted_form|. This is 432 // determine possible field types for the |submitted_form|. This is
429 // potentially expensive -- on the order of 50ms even for a small set of 433 // potentially expensive -- on the order of 50ms even for a small set of
430 // |stored_data|. Hence, it should not run on the UI thread -- to avoid 434 // |stored_data|. Hence, it should not run on the UI thread -- to avoid
431 // locking up the UI -- nor on the IO thread -- to avoid blocking IPC calls. 435 // locking up the UI -- nor on the IO thread -- to avoid blocking IPC calls.
432 static void DeterminePossibleFieldTypesForUpload( 436 static void DeterminePossibleFieldTypesForUpload(
433 const std::vector<AutofillProfile>& profiles, 437 const std::vector<AutofillProfile>& profiles,
434 const std::vector<CreditCard>& credit_cards, 438 const std::vector<CreditCard>& credit_cards,
435 const std::string& app_locale, 439 const std::string& app_locale,
436 FormStructure* submitted_form); 440 FormStructure* submitted_form);
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 600 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
597 OnLoadedServerPredictions_ResetManager); 601 OnLoadedServerPredictions_ResetManager);
598 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard); 602 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
599 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate); 603 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
600 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 604 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
601 }; 605 };
602 606
603 } // namespace autofill 607 } // namespace autofill
604 608
605 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 609 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698