Make CHECK int 3 on Windows, rather than crash

base/logging.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_LOGGING_H_
 #define BASE_LOGGING_H_
 
 #include <stddef.h>
 
 #include <cassert>
@@ skipping 443 matching lines @@
   // Returns true if the check succeeded.
   operator bool() const { return !message_; }
   // Returns the message.
   std::string* message() { return message_; }
 
  private:
   std::string* message_;
 };
 
 // Crashes in the fastest, simplest possible way with no attempt at logging.
-#if defined(COMPILER_GCC) || defined(__clang__)
+#if defined(COMPILER_GCC) || (defined(__clang__) && !defined(OS_WIN))
 #define IMMEDIATE_CRASH() __builtin_trap()
-#else
-#define IMMEDIATE_CRASH() ((void)(*(volatile char*)0 = 0))
+#elif defined(COMPILER_MSVC) || (defined(__clang__) && defined(OS_WIN))
+#define IMMEDIATE_CRASH() __debugbreak()

[Will Harris, 2017/02/02 03:12:03]

might be nice to have an #else and an #error here to point people at this code
if they do try and compile with something else, but no strong feelings, happy to
go with what OWNERS think.

[Primiano Tucci (use gerrit), 2017/02/03 03:15:05]

not an owner, but +1 to the #error pointing to crbug.com/664209 or anything else
that has an explanation of this esoteric piece of code

[scottmg, 2017/02/06 19:50:47]

That's why I left the deref null in the #else block. You prefer #error though?
Done.

 #endif
 
 // CHECK dies with a fatal error if condition is not true.  It is *not*
 // controlled by NDEBUG, so the check will be executed regardless of
 // compilation mode.
 //
 // We make sure CHECK et al. always evaluates their arguments, as
 // doing CHECK(FunctionWithSideEffect()) is a common idiom.
 
 #if defined(OFFICIAL_BUILD) && defined(NDEBUG)
@@ skipping 593 matching lines @@
 #elif NOTIMPLEMENTED_POLICY == 5
 #define NOTIMPLEMENTED() do {\
   static bool logged_once = false;\
   LOG_IF(ERROR, !logged_once) << NOTIMPLEMENTED_MSG;\
   logged_once = true;\
 } while(0);\
 EAT_STREAM_PARAMETERS
 #endif
 
 #endif  // BASE_LOGGING_H_