mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl - Issue 2676443005: Add interface versioning. Methods queryVersion and requireVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl

Issue 2676443005: Add interface versioning. Methods queryVersion and requireVersion. (Closed)

Patch Set: Expect the result inside the error handler for test. Code formatting and address codereview comment… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl

index eb73532d75921af310e37c9e2adbda83474153e4..54e2d4ebcf187e68193c57d78a565f0a1e06c97d 100644

--- a/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl

@@ -169,6 +169,7 @@ params.{{parameter.name}}{% if not loop.last %}, {% endif -%}

var {{interface.name}} = {

name: '{{namespace|replace(".","::")}}::{{interface.name}}',

+ kVersion: {{interface.version}},

ptrClass: {{interface.name}}Ptr,

proxyClass: {{interface.name}}Proxy,

stubClass: {{interface.name}}Stub,

« no previous file with comments | « mojo/public/js/validator.js ('k') | mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl » ('j') | no next file with comments »