Add interface versioning. Methods queryVersion and requireVersion.

mojo/public/js/tests/interface_ptr_unittest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 define([
     "gin/test/expect",
     "mojo/public/js/bindings",
     "mojo/public/js/core",
     "mojo/public/interfaces/bindings/tests/math_calculator.mojom",
+    "mojo/public/interfaces/bindings/tests/sample_interfaces.mojom",
     "mojo/public/js/threading",
     "gc",
 ], function(expect,
             bindings,
             core,
             math,
+            sampleInterfaces,
             threading,
             gc) {
   testIsBound()
       .then(testEndToEnd)
       .then(testReusable)
       .then(testConnectionError)
       .then(testPassInterface)
       .then(testBindRawHandle)
+      .then(testQueryVersion)
+      .then(testRequireVersion)
       .then(function() {
     this.result = "PASS";
     gc.collectGarbage();  // should not crash
     threading.quit();
   }.bind(this)).catch(function(e) {
     this.result = "FAIL: " + (e.stack || e);
     threading.quit();
   }.bind(this));
 
   function CalculatorImpl() {
     this.total = 0;
   }
 
   CalculatorImpl.prototype.clear = function() {
     this.total = 0;
     return Promise.resolve({value: this.total});
   };
 
   CalculatorImpl.prototype.add = function(value) {
     this.total += value;
     return Promise.resolve({value: this.total});
   };
 
   CalculatorImpl.prototype.multiply = function(value) {
     this.total *= value;
     return Promise.resolve({value: this.total});
   };
 
+  function IntegerAccessorImpl() {
+    this.integer = 0;
+  }
+
+  IntegerAccessorImpl.prototype.getInteger = function() {
+    return Promise.resolve({data: this.integer});
+  };
+
+  IntegerAccessorImpl.prototype.setInteger = function(value) {
+    this.integer = value;
+  };
+
   function testIsBound() {
     var calc = new math.CalculatorPtr();
     expect(calc.ptr.isBound()).toBeFalsy();
 
     var request = bindings.makeRequest(calc);
     expect(calc.ptr.isBound()).toBeTruthy();
 
     calc.ptr.reset();
     expect(calc.ptr.isBound()).toBeFalsy();
 
@@ skipping 88 matching lines @@
                                            new CalculatorImpl(),
                                            pipe.handle1);
 
     var promise = calc.add(2).then(function(response) {
       expect(response.value).toBe(2);
       return Promise.resolve();
     });
 
     return promise;
   }
+
+  function testQueryVersion() {
+    var integerAccessorPtr = new sampleInterfaces.IntegerAccessorPtr();
+
+    var integerAccessorBinding = new bindings.Binding(
+      sampleInterfaces.IntegerAccessor,

[yzshen1, 2017/02/11 01:11:29]

4 spaces
please see:
https://google.github.io/styleguide/javascriptguide.xml?showone=Code_formatti...

[wangjimmy, 2017/02/13 20:43:07]

Done.

+      new IntegerAccessorImpl(),
+      bindings.makeRequest(integerAccessorPtr)
+    );

[yzshen1, 2017/02/11 01:11:30]

");" should not be on a separate line.

[wangjimmy, 2017/02/13 20:43:07]

Done.

+    expect(integerAccessorPtr.ptr.version).toBe(0);
+
+    return integerAccessorPtr.ptr.queryVersion().then(function(version) {
+      expect(version).toBe(3);
+      expect(integerAccessorPtr.ptr.version).toBe(3);
+    });
+  }
+
+  function testRequireVersion() {
+    var integerAccessorImpl = new IntegerAccessorImpl();
+    var integerAccessorPtr = new sampleInterfaces.IntegerAccessorPtr();
+    var integerAccessorBinding = new bindings.Binding(
+      sampleInterfaces.IntegerAccessor,

[yzshen1, 2017/02/11 01:11:29]

4 spaces.

[wangjimmy, 2017/02/13 20:43:07]

Done.

+      integerAccessorImpl,
+      bindings.makeRequest(integerAccessorPtr));
+
+    // Inital version is 0.
+    expect(integerAccessorPtr.ptr.version).toBe(0);
+
+    function requireVersion1() {
+      integerAccessorPtr.ptr.requireVersion(1);
+      expect(integerAccessorPtr.ptr.version).toBe(1);
+      integerAccessorPtr.setInteger(123, sampleInterfaces.Enum.VALUE);
+      return integerAccessorPtr.getInteger().then(function(responseParams) {
+        expect(responseParams.data).toBe(123);
+      });
+    }
+
+    function requireVersion3() {
+      integerAccessorPtr.ptr.requireVersion(3);
+      expect(integerAccessorPtr.ptr.version).toBe(3);
+      integerAccessorPtr.setInteger(456, sampleInterfaces.Enum.VALUE);
+      return integerAccessorPtr.getInteger().then(function(responseParams) {
+        expect(responseParams.data).toBe(456);
+      });
+    }
+
+    // Require a version that is not supported by the impl side.
+    function requireVersion4() {
+      integerAccessorPtr.ptr.requireVersion(4);
+      expect(integerAccessorPtr.ptr.version).toBe(4);
+
+      var promise = new Promise(function(resolve, reject) {
+        integerAccessorPtr.ptr.setConnectionErrorHandler(function() {
+          resolve();
+        });
+      });
+
+      // The call to setInteger() after requireVersion(4) is ignored.
+      integerAccessorPtr.setInteger(789, sampleInterfaces.Enum.VALUE);
+      expect(integerAccessorImpl.integer).toBe(456);

[yzshen1, 2017/02/11 01:11:29]

Because the call on line 234 is completed asynchronously, it won't change the
value at this point. In order to really test that it is ignored, you should move
this line into the connection error handler on 229.

[wangjimmy, 2017/02/13 20:43:07]

Done.

+
+      return promise;
+    }
+
+    return requireVersion1().then(requireVersion3).then(requireVersion4);
+  }
 });