Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: mojo/public/js/router.js

Issue 2676443005: Add interface versioning. Methods queryVersion and requireVersion. (Closed)
Patch Set: Expect the result inside the error handler for test. Code formatting and address codereview comment… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 define("mojo/public/js/router", [ 5 define("mojo/public/js/router", [
6 "console", 6 "console",
7 "mojo/public/js/codec", 7 "mojo/public/js/codec",
8 "mojo/public/js/core", 8 "mojo/public/js/core",
9 "mojo/public/js/connector", 9 "mojo/public/js/connector",
10 "mojo/public/js/lib/control_message_handler",
10 "mojo/public/js/validator", 11 "mojo/public/js/validator",
11 ], function(console, codec, core, connector, validator) { 12 ], function(console, codec, core, connector, controlMessageHandler, validator) {
12 13
13 var Connector = connector.Connector; 14 var Connector = connector.Connector;
14 var MessageReader = codec.MessageReader; 15 var MessageReader = codec.MessageReader;
15 var Validator = validator.Validator; 16 var Validator = validator.Validator;
17 var ControlMessageHandler = controlMessageHandler.ControlMessageHandler;
16 18
17 function Router(handle, connectorFactory) { 19 function Router(handle, interface_version, connectorFactory) {
18 if (!core.isHandle(handle)) 20 if (!core.isHandle(handle))
19 throw new Error("Router constructor: Not a handle"); 21 throw new Error("Router constructor: Not a handle");
20 if (connectorFactory === undefined) 22 if (connectorFactory === undefined)
21 connectorFactory = Connector; 23 connectorFactory = Connector;
22 this.connector_ = new connectorFactory(handle); 24 this.connector_ = new connectorFactory(handle);
23 this.incomingReceiver_ = null; 25 this.incomingReceiver_ = null;
24 this.errorHandler_ = null; 26 this.errorHandler_ = null;
25 this.nextRequestID_ = 0; 27 this.nextRequestID_ = 0;
26 this.completers_ = new Map(); 28 this.completers_ = new Map();
27 this.payloadValidators_ = []; 29 this.payloadValidators_ = [];
28 this.testingController_ = null; 30 this.testingController_ = null;
29 31
32 if (interface_version !== undefined) {
33 this.controlMessageHandler_ = new
34 ControlMessageHandler(interface_version);
35 }
36
30 this.connector_.setIncomingReceiver({ 37 this.connector_.setIncomingReceiver({
31 accept: this.handleIncomingMessage_.bind(this), 38 accept: this.handleIncomingMessage_.bind(this),
32 }); 39 });
33 this.connector_.setErrorHandler({ 40 this.connector_.setErrorHandler({
34 onError: this.handleConnectionError_.bind(this), 41 onError: this.handleConnectionError_.bind(this),
35 }); 42 });
36 } 43 }
37 44
38 Router.prototype.close = function() { 45 Router.prototype.close = function() {
39 this.completers_.clear(); // Drop any responders. 46 this.completers_.clear(); // Drop any responders.
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 this.handleValidIncomingMessage_(message); 107 this.handleValidIncomingMessage_(message);
101 else 108 else
102 this.handleInvalidIncomingMessage_(message, err); 109 this.handleInvalidIncomingMessage_(message, err);
103 }; 110 };
104 111
105 Router.prototype.handleValidIncomingMessage_ = function(message) { 112 Router.prototype.handleValidIncomingMessage_ = function(message) {
106 if (this.testingController_) 113 if (this.testingController_)
107 return; 114 return;
108 115
109 if (message.expectsResponse()) { 116 if (message.expectsResponse()) {
110 if (this.incomingReceiver_) { 117 if (controlMessageHandler.isControlMessage(message)) {
118 if (this.controlMessageHandler_) {
119 this.controlMessageHandler_.acceptWithResponder(message, this);
120 } else {
121 this.close();
122 }
123 } else if (this.incomingReceiver_) {
111 this.incomingReceiver_.acceptWithResponder(message, this); 124 this.incomingReceiver_.acceptWithResponder(message, this);
112 } else { 125 } else {
113 // If we receive a request expecting a response when the client is not 126 // If we receive a request expecting a response when the client is not
114 // listening, then we have no choice but to tear down the pipe. 127 // listening, then we have no choice but to tear down the pipe.
115 this.close(); 128 this.close();
116 } 129 }
117 } else if (message.isResponse()) { 130 } else if (message.isResponse()) {
118 var reader = new MessageReader(message); 131 var reader = new MessageReader(message);
119 var requestID = reader.requestID; 132 var requestID = reader.requestID;
120 var completer = this.completers_.get(requestID); 133 var completer = this.completers_.get(requestID);
121 if (completer) { 134 if (completer) {
122 this.completers_.delete(requestID); 135 this.completers_.delete(requestID);
123 completer.resolve(message); 136 completer.resolve(message);
124 } else { 137 } else {
125 console.log("Unexpected response with request ID: " + requestID); 138 console.log("Unexpected response with request ID: " + requestID);
126 } 139 }
127 } else { 140 } else {
128 if (this.incomingReceiver_) 141 if (controlMessageHandler.isControlMessage(message)) {
142 if (this.controlMessageHandler_) {
143 var ok = this.controlMessageHandler_.accept(message);
144 if (ok) return;
145 }
146 this.close();
147 } else if (this.incomingReceiver_) {
129 this.incomingReceiver_.accept(message); 148 this.incomingReceiver_.accept(message);
149 }
130 } 150 }
131 }; 151 };
132 152
133 Router.prototype.handleInvalidIncomingMessage_ = function(message, error) { 153 Router.prototype.handleInvalidIncomingMessage_ = function(message, error) {
134 if (!this.testingController_) { 154 if (!this.testingController_) {
135 // TODO(yzshen): Consider notifying the embedder. 155 // TODO(yzshen): Consider notifying the embedder.
136 // TODO(yzshen): This should also trigger connection error handler. 156 // TODO(yzshen): This should also trigger connection error handler.
137 // Consider making accept() return a boolean and let the connector deal 157 // Consider making accept() return a boolean and let the connector deal
138 // with this, as the C++ code does. 158 // with this, as the C++ code does.
139 console.log("Invalid message: " + validator.validationError[error]); 159 console.log("Invalid message: " + validator.validationError[error]);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 RouterTestingController.prototype.onInvalidIncomingMessage = 194 RouterTestingController.prototype.onInvalidIncomingMessage =
175 function(error) { 195 function(error) {
176 if (this.invalidMessageHandler_) 196 if (this.invalidMessageHandler_)
177 this.invalidMessageHandler_(error); 197 this.invalidMessageHandler_(error);
178 }; 198 };
179 199
180 var exports = {}; 200 var exports = {};
181 exports.Router = Router; 201 exports.Router = Router;
182 return exports; 202 return exports;
183 }); 203 });
OLDNEW
« no previous file with comments | « mojo/public/js/lib/control_message_proxy.js ('k') | mojo/public/js/tests/interface_ptr_unittest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698