Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBKey.h

Issue 2676403003: IndexedDB: Add histograms for key type (Closed)
Patch Set: Leave number off enum max Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBKey.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBKey.h b/third_party/WebKit/Source/modules/indexeddb/IDBKey.h
index 4b9ff354ec8b6fc7d97572886c98e97731d8848e..be542af81fd22e1437a63bace19f71e790ff3a2f 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBKey.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBKey.h
@@ -63,14 +63,16 @@ class MODULES_EXPORT IDBKey : public GarbageCollectedFinalized<IDBKey> {
DECLARE_TRACE();
// In order of the least to the highest precedent in terms of sort order.
+ // These values are written to logs. New enum values can be added, but
+ // existing enums must never be renumbered or deleted and reused.
enum Type {
InvalidType = 0,
- ArrayType,
- BinaryType,
- StringType,
- DateType,
- NumberType,
- MinType
+ ArrayType = 1,
+ BinaryType = 2,
+ StringType = 3,
+ DateType = 4,
+ NumberType = 5,
+ TypeEnumMax,
};
Type getType() const { return m_type; }

Powered by Google App Engine
This is Rietveld 408576698