third_party/WebKit/Source/web/WebIDBKey.cpp - Issue 2676403003: IndexedDB: Add histograms for key type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebIDBKey.cpp

Issue 2676403003: IndexedDB: Add histograms for key type (Closed)

Patch Set: Record index key types too Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebIDBKey.cpp

diff --git a/third_party/WebKit/Source/web/WebIDBKey.cpp b/third_party/WebKit/Source/web/WebIDBKey.cpp

index 187ee5d219359e654d34ddd52e1c26eb14e11ee4..64fb49062d6b12394deffdf31f0a05d387e2abd5 100644

--- a/third_party/WebKit/Source/web/WebIDBKey.cpp

+++ b/third_party/WebKit/Source/web/WebIDBKey.cpp

@@ -139,9 +139,6 @@ static void convertToWebIDBKeyArray(const IDBKey::KeyArray& array,

case IDBKey::InvalidType:

keys[i] = WebIDBKey::createInvalid();

break;

- case IDBKey::MinType:

- NOTREACHED();

- break;

}

result.swap(keys);