third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp - Issue 2676403003: IndexedDB: Add histograms for key type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 2676403003: IndexedDB: Add histograms for key type (Closed)

Patch Set: Record index key types too Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

index 7f2bdfc2ab75ece2dfe40793252dbbfc4ea7244e..259fe2eca68484bd5cc3182da600e9fcf50beed5 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

@@ -96,7 +96,6 @@ v8::Local<v8::Value> ToV8(const IDBKey* key,

switch (key->getType()) {

case IDBKey::InvalidType:

- case IDBKey::MinType:

ASSERT_NOT_REACHED();

return v8Undefined();

case IDBKey::NumberType:

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/indexeddb/IDBKey.h » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBKey.h » ('J')