Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2676403003: IndexedDB: Add histograms for key type (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4400ab149aff1b051521b1e463b5e4a144f509e0..674687b98f888643e5bdf3dac077928c8a05fdff 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -74494,6 +74494,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="WebCore.IndexedDB.ObjectStoreRecord.KeyType" enum="IDBKeyType">
+ <owner>jsbell@chromium.org</owner>
+ <summary>
+ The type of key (number, string, etc.) used for a record being
+ stored/updated in an Indexed DB object store.
+ </summary>
+</histogram>
+
<histogram name="WebCore.IndexedDB.OpenTime.Blocked" units="ms">
<owner>cmumford@chromium.org</owner>
<summary>
@@ -93700,6 +93708,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="2" label="Array">Key path is an array of strings.</int>
</enum>
+<enum name="IDBKeyType" type="int">
+ <int value="0" label="Invalid">Invalid key.</int>
cmumford 2017/02/07 20:10:37 This will never be logged right? If so how about d
jsbell 2017/02/07 21:58:24 Correct, it should never be logged. mpearson@ - w
Mark P 2017/02/07 22:59:46 It could go either way in this case. It depends i
+ <int value="1" label="Array">Key is an array of other keys.</int>
+ <int value="2" label="Binary">Key is a binary buffer.</int>
+ <int value="3" label="String">Key is a string.</int>
+ <int value="4" label="Date">Key is a date.</int>
+ <int value="5" label="Number">Key is a number.</int>
+</enum>
+
<enum name="IDBLevelDBBackingStoreInternalErrorType" type="int">
<int value="0" label="IDBLevelDBBackingStoreReadError">
IndexedDB encountered an error attempting to read or decode a value from the

Powered by Google App Engine
This is Rietveld 408576698