IndexedDB: Add histograms for key type

third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
  *     documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "modules/indexeddb/IDBObjectStore.h"
 
+#include <v8.h>

[cmumford, 2017/02/07 20:10:37]

I think it was correct to move <memory> up here, but v8.h should be down below
where it was.

[jsbell, 2017/02/07 21:58:24]

D'oh - it should be further down at any rate.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
says: Related header, C library, C++ library, other libraries' .h, your
project's .h.

So as a "other libraries' .h" v8.h would be below C++ library and above "your
project's .h" ? But per the blink-dev PSA thread on blink-dev, maybe we'll
change this to "v8/include/v8.h"

`git cl format` doesn't let `#include <x.h>` follow `#include "y.h"` in the same
block, so it can't stay where it is.

+
+#include <memory>
+
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
 #include "bindings/modules/v8/ToV8ForModules.h"
 #include "bindings/modules/v8/V8BindingForModules.h"
 #include "core/dom/DOMStringList.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "modules/indexeddb/IDBAny.h"
 #include "modules/indexeddb/IDBCursorWithValue.h"
 #include "modules/indexeddb/IDBDatabase.h"
 #include "modules/indexeddb/IDBKeyPath.h"
 #include "modules/indexeddb/IDBTracing.h"
+#include "platform/Histogram.h"
 #include "platform/SharedBuffer.h"
 #include "public/platform/WebBlobInfo.h"
 #include "public/platform/WebData.h"
 #include "public/platform/WebVector.h"
 #include "public/platform/modules/indexeddb/WebIDBKey.h"
 #include "public/platform/modules/indexeddb/WebIDBKeyRange.h"
-#include <memory>
-#include <v8.h>
 
 using blink::WebBlobInfo;
 using blink::WebIDBCallbacks;
 using blink::WebIDBCursor;
 using blink::WebIDBDatabase;
 using blink::WebVector;
 
 namespace blink {
 
 namespace {
@@ skipping 381 matching lines @@
   }
 
   if (!usesInLineKeys && !hasKeyGenerator && !key) {
     exceptionState.throwDOMException(DataError,
                                      "The object store uses out-of-line keys "
                                      "and has no key generator and the key "
                                      "parameter was not provided.");
     return nullptr;
   }
   if (usesInLineKeys) {
-    if (clone.isEmpty())
+    if (clone.isEmpty()) {
       clone =
           deserializeScriptValue(scriptState, serializedValue.get(), &blobInfo);
+    }
     IDBKey* keyPathKey = ScriptValue::to<IDBKey*>(scriptState->isolate(), clone,
                                                   exceptionState, keyPath);
     if (exceptionState.hadException())
       return nullptr;
     if (keyPathKey && !keyPathKey->isValid()) {
       exceptionState.throwDOMException(DataError,
                                        "Evaluating the object store's key path "
                                        "yielded a value that is not a valid "
                                        "key.");
       return nullptr;
@@ skipping 20 matching lines @@
                                      IDBDatabase::notValidKeyErrorMessage);
     return nullptr;
   }
 
   if (!backendDB()) {
     exceptionState.throwDOMException(InvalidStateError,
                                      IDBDatabase::databaseClosedErrorMessage);
     return nullptr;
   }
 
+  if (key && usesInLineKeys) {
+    DEFINE_THREAD_SAFE_STATIC_LOCAL(
+        EnumerationHistogram, keyTypeHistogram,
+        new EnumerationHistogram("WebCore.IndexedDB.ObjectStoreRecord.KeyType",
+                                 static_cast<int>(IDBKey::TypeEnumMax)));
+    keyTypeHistogram.count(static_cast<int>(key->getType()));
+  }
+
   Vector<int64_t> indexIds;
   HeapVector<IndexKeys> indexKeys;
   for (const auto& it : metadata().indexes) {
-    if (clone.isEmpty())
+    if (clone.isEmpty()) {
       clone =
           deserializeScriptValue(scriptState, serializedValue.get(), &blobInfo);
+    }
     IndexKeys keys;
     generateIndexKeysForValue(scriptState->isolate(), *it.value, clone, &keys);
     indexIds.push_back(it.key);
     indexKeys.push_back(keys);
   }
 
   IDBRequest* request =
       IDBRequest::create(scriptState, source, m_transaction.get());
   Vector<char> wireBytes;
   serializedValue->toWireBytes(wireBytes);
@@ skipping 579 matching lines @@
     }
   }
   return IDBIndexMetadata::InvalidId;
 }
 
 WebIDBDatabase* IDBObjectStore::backendDB() const {
   return m_transaction->backendDB();
 }
 
 }  // namespace blink