Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4523)

Unified Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 2676393002: Extensions: Only display host name for the overridden home and start-up pages. (Closed)
Patch Set: Address review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/settings_override_permission_unittest.cc
diff --git a/chrome/common/extensions/permissions/settings_override_permission_unittest.cc b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc
index 266bb8881f9b16e0d2f6e31bd602fba5e33426d6..421a01d8f32fcae4d16b42d9b53e6203533752a3 100644
--- a/chrome/common/extensions/permissions/settings_override_permission_unittest.cc
+++ b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc
@@ -49,7 +49,7 @@ class SettingsOverridePermissionTest : public ChromeManifestTest {
std::unique_ptr<base::DictionaryValue> settings_override(
new base::DictionaryValue);
if (flags & kHomepage)
- settings_override->SetString("homepage", "http://www.google.com");
+ settings_override->SetString("homepage", "http://www.google.com/home");
if (flags & kStartupPages) {
std::unique_ptr<base::ListValue> startup_pages(new base::ListValue);
startup_pages->AppendString("http://startup.com/startup.html");
@@ -88,7 +88,7 @@ TEST_F(SettingsOverridePermissionTest, HomePage) {
#if defined(OS_WIN) || defined(OS_MACOSX)
EXPECT_TRUE(permission_set.HasAPIPermission(APIPermission::kHomepage));
VerifyOnePermissionMessage(extension->permissions_data(),
- "Change your home page to: google.com/");
+ "Change your home page to: google.com");
#else
EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage));
#endif
@@ -104,9 +104,8 @@ TEST_F(SettingsOverridePermissionTest, StartupPages) {
#if defined(OS_WIN) || defined(OS_MACOSX)
EXPECT_TRUE(permission_set.HasAPIPermission(APIPermission::kStartupPages));
- VerifyOnePermissionMessage(
- extension->permissions_data(),
- "Change your start page to: startup.com/startup.html");
+ VerifyOnePermissionMessage(extension->permissions_data(),
+ "Change your start page to: startup.com");
#else
EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages));
#endif
« no previous file with comments | « chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698