Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 2676393002: Extensions: Only display host name for the overridden home and start-up pages. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure SettingsOverridePermission values are set correctly. 5 // These tests make sure SettingsOverridePermission values are set correctly.
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 scoped_refptr<Extension> GetPermissionSet(uint32_t flags) { 43 scoped_refptr<Extension> GetPermissionSet(uint32_t flags) {
44 base::DictionaryValue ext_manifest; 44 base::DictionaryValue ext_manifest;
45 ext_manifest.SetString(manifest_keys::kName, "test"); 45 ext_manifest.SetString(manifest_keys::kName, "test");
46 ext_manifest.SetString(manifest_keys::kVersion, "0.1"); 46 ext_manifest.SetString(manifest_keys::kVersion, "0.1");
47 ext_manifest.SetInteger(manifest_keys::kManifestVersion, 2); 47 ext_manifest.SetInteger(manifest_keys::kManifestVersion, 2);
48 48
49 std::unique_ptr<base::DictionaryValue> settings_override( 49 std::unique_ptr<base::DictionaryValue> settings_override(
50 new base::DictionaryValue); 50 new base::DictionaryValue);
51 if (flags & kHomepage) 51 if (flags & kHomepage)
52 settings_override->SetString("homepage", "http://www.google.com"); 52 settings_override->SetString("homepage", "http://www.google.com/home");
53 if (flags & kStartupPages) { 53 if (flags & kStartupPages) {
54 std::unique_ptr<base::ListValue> startup_pages(new base::ListValue); 54 std::unique_ptr<base::ListValue> startup_pages(new base::ListValue);
55 startup_pages->AppendString("http://startup.com/startup.html"); 55 startup_pages->AppendString("http://startup.com/startup.html");
56 settings_override->Set("startup_pages", startup_pages.release()); 56 settings_override->Set("startup_pages", startup_pages.release());
57 } 57 }
58 if (flags & kSearchProvider) { 58 if (flags & kSearchProvider) {
59 std::unique_ptr<base::DictionaryValue> search_provider( 59 std::unique_ptr<base::DictionaryValue> search_provider(
60 new base::DictionaryValue); 60 new base::DictionaryValue);
61 search_provider->SetString("search_url", "http://google.com/search.html"); 61 search_provider->SetString("search_url", "http://google.com/search.html");
62 search_provider->SetString("name", "test"); 62 search_provider->SetString("name", "test");
(...skipping 18 matching lines...) Expand all
81 }; 81 };
82 82
83 TEST_F(SettingsOverridePermissionTest, HomePage) { 83 TEST_F(SettingsOverridePermissionTest, HomePage) {
84 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage)); 84 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage));
85 const PermissionSet& permission_set = 85 const PermissionSet& permission_set =
86 extension->permissions_data()->active_permissions(); 86 extension->permissions_data()->active_permissions();
87 87
88 #if defined(OS_WIN) || defined(OS_MACOSX) 88 #if defined(OS_WIN) || defined(OS_MACOSX)
89 EXPECT_TRUE(permission_set.HasAPIPermission(APIPermission::kHomepage)); 89 EXPECT_TRUE(permission_set.HasAPIPermission(APIPermission::kHomepage));
90 VerifyOnePermissionMessage(extension->permissions_data(), 90 VerifyOnePermissionMessage(extension->permissions_data(),
91 "Change your home page to: google.com/"); 91 "Change your home page to: google.com");
92 #else 92 #else
93 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage)); 93 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage));
94 #endif 94 #endif
95 95
96 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages)); 96 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages));
97 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider)); 97 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider));
98 } 98 }
99 99
100 TEST_F(SettingsOverridePermissionTest, StartupPages) { 100 TEST_F(SettingsOverridePermissionTest, StartupPages) {
101 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages)); 101 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages));
102 const PermissionSet& permission_set = 102 const PermissionSet& permission_set =
103 extension->permissions_data()->active_permissions(); 103 extension->permissions_data()->active_permissions();
104 104
105 #if defined(OS_WIN) || defined(OS_MACOSX) 105 #if defined(OS_WIN) || defined(OS_MACOSX)
106 EXPECT_TRUE(permission_set.HasAPIPermission(APIPermission::kStartupPages)); 106 EXPECT_TRUE(permission_set.HasAPIPermission(APIPermission::kStartupPages));
107 VerifyOnePermissionMessage( 107 VerifyOnePermissionMessage(extension->permissions_data(),
108 extension->permissions_data(), 108 "Change your start page to: startup.com");
109 "Change your start page to: startup.com/startup.html");
110 #else 109 #else
111 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages)); 110 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages));
112 #endif 111 #endif
113 112
114 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage)); 113 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage));
115 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider)); 114 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider));
116 } 115 }
117 116
118 TEST_F(SettingsOverridePermissionTest, SearchSettings) { 117 TEST_F(SettingsOverridePermissionTest, SearchSettings) {
119 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider)); 118 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider));
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage)); 161 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage));
163 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider)); 162 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider));
164 #endif 163 #endif
165 164
166 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages)); 165 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages));
167 } 166 }
168 167
169 } // namespace 168 } // namespace
170 169
171 } // namespace extensions 170 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698