Implement service-side surface synchronization

cc/surfaces/surface_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/surface_factory.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 47 matching lines @@
   TRACE_EVENT0("cc", "SurfaceFactory::SubmitCompositorFrame");
   DCHECK(local_surface_id.is_valid());
   std::unique_ptr<Surface> surface;
   bool create_new_surface =
       (!current_surface_ ||
        local_surface_id != current_surface_->surface_id().local_surface_id());
   if (!create_new_surface) {
     surface = std::move(current_surface_);
   } else {
     surface = Create(local_surface_id);
-    gfx::Size frame_size;
-    // CompositorFrames may not be populated with a RenderPass in unit tests.
-    if (!frame.render_pass_list.empty())
-      frame_size = frame.render_pass_list.back()->output_rect.size();
-    manager_->SurfaceCreated(SurfaceInfo(
-        surface->surface_id(), frame.metadata.device_scale_factor, frame_size));
   }
   surface->QueueFrame(std::move(frame), callback);
+
   if (!manager_->SurfaceModified(SurfaceId(frame_sink_id_, local_surface_id))) {
     TRACE_EVENT_INSTANT0("cc", "Damage not visible.", TRACE_EVENT_SCOPE_THREAD);
     surface->RunDrawCallbacks();
   }
   if (current_surface_ && create_new_surface) {
     surface->SetPreviousFrameSurface(current_surface_.get());
     Destroy(std::move(current_surface_));
   }
   current_surface_ = std::move(surface);
 }
@@ skipping 27 matching lines @@
 }
 
 void SurfaceFactory::RefResources(const TransferableResourceArray& resources) {
   holder_.RefResources(resources);
 }
 
 void SurfaceFactory::UnrefResources(const ReturnedResourceArray& resources) {
   holder_.UnrefResources(resources);
 }
 
+void SurfaceFactory::OnSurfaceActivated(Surface* surface) {
+  const CompositorFrame& frame = surface->GetActiveFrame();

[vmpstr, 2017/02/07 22:46:20]

DCHECK that it hasactiveframe

[Fady Samuel, 2017/02/08 00:52:50]

Done.

+  // CompositorFrames may not be populated with a RenderPass in unit tests.

[vmpstr, 2017/02/07 22:46:20]

nit: this reads like unittests are not allowed to populate it with a render
pass... maybe s/may/might/? *shrug*

[Fady Samuel, 2017/02/08 00:52:50]

Done.

+  gfx::Size frame_size;
+  if (!frame.render_pass_list.empty())
+    frame_size = frame.render_pass_list.back()->output_rect.size();
+
+  // SurfaceCreated only applies for the first Surface activation. Thus,
+  // SurfaceFactory stops observing new activations after the first one.
+  manager_->SurfaceCreated(SurfaceInfo(
+      surface->surface_id(), frame.metadata.device_scale_factor, frame_size));
+  surface->RemoveObserver(this);

[vmpstr, 2017/02/07 22:46:20]

Is there a doc describing who observes whom and for how long and why? This patch
looks to be adding a few more places where we observe or not observe, and I
think having a central doc with all of the relationships might be good for
posterity.

[Fady Samuel, 2017/02/08 00:52:50]

SurfaceFactory is going away soon, but SurfaceDependencyTracker observes
surfaces too. I think that's about it. I'll write a quick summary too, but I
fear it'll go out of date very quickly.

+}
+
+void SurfaceFactory::OnSurfaceChanged(
+    Surface* pending_surface,
+    const SurfaceDependencies& added_dependencies,
+    const SurfaceDependencies& removed_dependencies) {}
+
+void SurfaceFactory::OnSurfaceDiscarded(Surface* pending_surface) {}
+
 std::unique_ptr<Surface> SurfaceFactory::Create(
     const LocalSurfaceId& local_surface_id) {
   auto surface = base::MakeUnique<Surface>(
       SurfaceId(frame_sink_id_, local_surface_id), weak_factory_.GetWeakPtr());
   manager_->RegisterSurface(surface.get());
+  // Observe a Surface from the time it's created until it's activated for the
+  // first time.
+  surface->AddObserver(this);
   return surface;
 }
 
 void SurfaceFactory::Destroy(std::unique_ptr<Surface> surface) {
+  surface->RemoveObserver(this);
   if (manager_)
     manager_->Destroy(std::move(surface));
 }
 
 }  // namespace cc