cc/ipc/compositor_frame_metadata.mojom - Issue 2676373004: Implement service-side surface synchronization

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/ipc/compositor_frame_metadata.mojom

Issue 2676373004: Implement service-side surface synchronization (Closed)

Patch Set: DisplayCompositorLockManager => SurfaceDependencyTracker. Added More Comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | cc/ipc/compositor_frame_metadata_struct_traits.h » ('j') | cc/surfaces/pending_frame_observer.h » ('J')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module cc.mojom;	5 module cc.mojom;

6	6

7 import "cc/ipc/selection.mojom";	7 import "cc/ipc/selection.mojom";

8 import "cc/ipc/surface_id.mojom";	8 import "cc/ipc/surface_id.mojom";

9 import "ui/events/mojo/latency_info.mojom";	9 import "ui/events/mojo/latency_info.mojom";

10 import "ui/gfx/geometry/mojo/geometry.mojom";	10 import "ui/gfx/geometry/mojo/geometry.mojom";

(...skipping 12 matching lines...) Expand all Loading...
23 bool may_contain_video;	23 bool may_contain_video;

24 bool is_resourceless_software_draw_with_scroll_or_animation;	24 bool is_resourceless_software_draw_with_scroll_or_animation;

25 float top_controls_height;	25 float top_controls_height;

26 float top_controls_shown_ratio;	26 float top_controls_shown_ratio;

27 float bottom_controls_height;	27 float bottom_controls_height;

28 float bottom_controls_shown_ratio;	28 float bottom_controls_shown_ratio;

29 uint32 root_background_color;	29 uint32 root_background_color;

30 Selection selection;	30 Selection selection;

31 array<ui.mojom.LatencyInfo> latency_info;	31 array<ui.mojom.LatencyInfo> latency_info;

32 array<SurfaceId> referenced_surfaces;	32 array<SurfaceId> referenced_surfaces;

	33 bool respect_deadline;
	vmpstr 2017/02/07 22:46:19 As an aside, should there some ordering to these v As an aside, should there some ordering to these variables with respect to types? I'm not sure how mojo structs work, but in C++ for example (on my machine) struct { bool b1; int i; bool b2; }; is 12 bytes, where as struct { int i; bool b1; bool b2; }; is 8 bytes. (padding ftl). Fady Samuel 2017/02/08 00:52:48 Yes, we should probably move all bools to the bott Show quoted text On 2017/02/07 22:46:19, vmpstr wrote: > As an aside, should there some ordering to these variables with respect to > types? I'm not sure how mojo structs work, but in C++ for example (on my > machine) > > struct { > bool b1; > int i; > bool b2; > }; > > is 12 bytes, where as > > struct { > int i; > bool b1; > bool b2; > }; > > is 8 bytes. (padding ftl). > Yes, we should probably move all bools to the bottom, but I won't do it in this CL to confuse matters.
33 };	34 };

OLD	NEW