Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2676363003: Add EvictingFileByteStore and make FileByteStore non-evicting. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add EvictingFileByteStore and make FileByteStore non-evicting. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0c19c418c24e8b43126dfef4ee8c00fab8aa72c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -38 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart View 4 chunks +62 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-06 18:07:11 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-06 18:08:39 UTC) #2
scheglov
3 years, 10 months ago (2017-02-06 18:10:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c19c418c24e8b43126dfef4ee8c00fab8aa72c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698