MojoCompositorFrameSinkPrivate should support copy requests

cc/surfaces/compositor_frame_sink_support.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/compositor_frame_sink_support.h"
 
 #include "cc/output/compositor_frame.h"
 #include "cc/scheduler/begin_frame_source.h"
 #include "cc/surfaces/compositor_frame_sink_support_client.h"
 #include "cc/surfaces/display.h"
@@ skipping 161 matching lines @@
   if (needs_begin_frame_ == added_frame_observer_)
     return;
 
   added_frame_observer_ = needs_begin_frame_;
   if (needs_begin_frame_)
     begin_frame_source_->AddObserver(this);
   else
     begin_frame_source_->RemoveObserver(this);
 }
 
+void CompositorFrameSinkSupport::RequestCopyOfSurface(
+    std::unique_ptr<CopyOutputRequest> request) {
+  request->set_result_callback(
+      base::Bind(&CompositorFrameSinkSupport::OnTextureReceived,
+                 weak_factory_.GetWeakPtr(), request->result_callback()));
+  surface_factory_.RequestCopyOfSurface(std::move(request));
+}
+
+void CompositorFrameSinkSupport::ReleaseCopyOfSurface(
+    const gpu::Mailbox& mailbox,
+    const gpu::SyncToken& sync_token,
+    bool is_lost) {
+  auto callback_iter = release_callbacks_.find(mailbox);
+  if (!release_callbacks_.count(mailbox)) {
+    DLOG(ERROR) << "Attempted to delete a mailbox that does not exist";
+    return;
+  }
+  callback_iter->second->Run(sync_token, is_lost);
+  release_callbacks_.erase(callback_iter);
+}
+
+void CompositorFrameSinkSupport::OnTextureReceived(
+    CopyOutputRequest::CopyOutputRequestCallback callback,
+    std::unique_ptr<CopyOutputResult> result) {
+  DCHECK(result->HasTexture());
+  DCHECK(!release_callbacks_.count(result->mailbox()));
+  release_callbacks_[result->mailbox()] = result->TakeReleaseCallback();
+  callback.Run(std::move(result));

[danakj, 2017/02/06 23:02:12]

The result here should have a release callback to calls to ReleaseCopyOfSurface.
It looks like you want a CreateRelayResult similar to CreateRelayRequest? It can
move the contents of the original from it store a new release callback.

It's super not valid to give back a result without the release callback.

[Saman Sami, 2017/02/06 23:09:54]

I can't set the release callback here. Remember that it will be lost over mojo,
so there is no point. The client of MojoCompositorFrameSinkPrivate is required
to set the release callback appropriately.

[danakj, 2017/02/06 23:24:08]

There should be a release callback made when it comes out of mojo too.

[danakj, 2017/02/06 23:24:44]

And if you don't do this here, how does the texture ever get returned in the
current patch? Clients will try to use that callback.

+}
+
 }  // namespace cc