Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/domain_reliability/context.cc

Issue 267633002: Domain Reliability: Don't send proxy address, other fixes (Closed) Base URL: http://git.chromium.org/chromium/src.git@domrel_security
Patch Set: Include https://codereview.chromium.org/271593002/ Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/config_unittest.cc ('k') | components/domain_reliability/context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/context.cc
diff --git a/components/domain_reliability/context.cc b/components/domain_reliability/context.cc
index 3805c1d9ff043bc4e6407753197785968696038b..ce8a6bb50d28b27661155ad9ccbe232e384aef6f 100644
--- a/components/domain_reliability/context.cc
+++ b/components/domain_reliability/context.cc
@@ -141,9 +141,9 @@ void DomainReliabilityContext::OnBeacon(const GURL& url,
return;
DCHECK_GT(states_.size(), index);
+ bool success = (beacon.status == "ok");
+
ResourceState* state = states_[index];
- bool success = beacon.http_response_code >= 200 &&
- beacon.http_response_code < 400;
if (success)
++state->successful_requests;
else
« no previous file with comments | « components/domain_reliability/config_unittest.cc ('k') | components/domain_reliability/context_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698