Domain Reliability: Don't send proxy address, other fixes

components/domain_reliability/context.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/context.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/json/json_writer.h"
@@ skipping 123 matching lines @@
 
 DomainReliabilityContext::~DomainReliabilityContext() {}
 
 void DomainReliabilityContext::OnBeacon(const GURL& url,
                                         const DomainReliabilityBeacon& beacon) {
   size_t index = config_->GetResourceIndexForUrl(url);
   if (index == DomainReliabilityConfig::kInvalidResourceIndex)
     return;
   DCHECK_GT(states_.size(), index);
 
+  bool success = (beacon.status == "ok");

[Ryan Sleevi, 2014/05/06 22:43:42]

unrelated?

[Deprecated (see juliatuttle), 2014/05/07 03:13:09]

Yes, but I spotted it writing unittests :)

+
   ResourceState* state = states_[index];
-  bool success = beacon.http_response_code >= 200 &&
-                 beacon.http_response_code < 400;
   if (success)
     ++state->successful_requests;
   else
     ++state->failed_requests;
 
   bool reported = false;
   bool evicted = false;
   if (state->config->DecideIfShouldReportRequest(success)) {
     state->beacons.push_back(beacon);
     ++beacon_count_;
@@ skipping 130 matching lines @@
 
   min_resource->RemoveOldestBeacon();
   --beacon_count_;
   // If that just removed a beacon counted in uploading_beacon_count_, decrement
   // that.
   if (uploading_beacon_count_ > 0)
     --uploading_beacon_count_;
 }
 
 }  // namespace domain_reliability