net/proxy/proxy_config_service_android.h - Issue 26763005: android: Use new proxy from PROXY_CHANGE intent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_config_service_android.h

Issue 26763005: android: Use new proxy from PROXY_CHANGE intent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Use ConvertJavaStringToUTF8 Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_config_service_android.h

diff --git a/net/proxy/proxy_config_service_android.h b/net/proxy/proxy_config_service_android.h

index 3ddbaebe78e9ead4b3e73567bbb7a74c784f587e..2b22daad75bb03b3adbfc7d0a03dcdc8e5c28fe3 100644

--- a/net/proxy/proxy_config_service_android.h

+++ b/net/proxy/proxy_config_service_android.h

@@ -40,7 +40,7 @@ class NET_EXPORT ProxyConfigServiceAndroid : public ProxyConfigService {

// Called from Java (on JNI thread) to signal that the proxy settings have

// changed.

cbentzel 2013/10/15 18:59:42 Can you document this? In particular, the semantic

Elly Fong-Jones 2013/10/15 19:50:42 Done.

- virtual void ProxySettingsChanged(JNIEnv*, jobject) = 0;

+ virtual void ProxySettingsChanged(JNIEnv*, jobject, jstring, jint) = 0;

};

ProxyConfigServiceAndroid(base::SequencedTaskRunner* network_task_runner,