Vector stores Expression object as OwnPtr instead of raw pointer in XPath.

Source/core/xml/XPathPath.cpp

 /*
  * Copyright (C) 2005 Frerich Raabe <raabe@kde.org>
  * Copyright (C) 2006, 2009 Apple Inc.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 18 matching lines @@
 #include "core/xml/XPathPath.h"
 
 #include "core/dom/Document.h"
 #include "core/xml/XPathPredicate.h"
 #include "core/xml/XPathStep.h"
 #include "core/xml/XPathValue.h"
 
 namespace WebCore {
 namespace XPath {
 
-Filter::Filter(Expression* expr, const Vector<Predicate*>& predicates)
-    : m_expr(expr), m_predicates(predicates)
+Filter::Filter(PassOwnPtr<Expression> expr, const Vector<Predicate*>& predicates)
+    : m_expr(expr)
 {
+    m_predicates.reserveInitialCapacity(predicates.size());
+    for (size_t i = 0; i < predicates.size(); i++)
+        m_predicates.append(adoptPtr(predicates[i]));
+

[dshwang, 2013/10/14 15:56:04]

As I mentioned above, Vector<OwnPtr<>> copy constructor fail to compile.

I'll fix Vector and then change Vector<Predicate*> to Vector<OwnPtr<Predicate> >
in whole XPath code.

[abarth-chromium, 2013/10/15 17:51:36]

Great!

     setIsContextNodeSensitive(m_expr->isContextNodeSensitive());
     setIsContextPositionSensitive(m_expr->isContextPositionSensitive());
     setIsContextSizeSensitive(m_expr->isContextSizeSensitive());
 }
 
 Filter::~Filter()
 {
-    delete m_expr;
-    deleteAllValues(m_predicates);
 }
 
 Value Filter::evaluate() const
 {
     Value v = m_expr->evaluate();
 
     NodeSet& nodes = v.modifiableNodeSet();
     nodes.sort();
 
     EvaluationContext& evaluationContext = Expression::evaluationContext();
@@ skipping 145 matching lines @@
     Value v = m_filter->evaluate();
 
     NodeSet& nodes = v.modifiableNodeSet();
     m_path->evaluate(nodes);
 
     return v;
 }
 
 }
 }