Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3160)

Unified Diff: chrome/common/extensions/api/webrtc_logging_private.idl

Issue 267623003: Adds StartRtpDump and StopRtpDump methods to webrtcLoggingPrivate API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/webrtc_logging_private.idl
diff --git a/chrome/common/extensions/api/webrtc_logging_private.idl b/chrome/common/extensions/api/webrtc_logging_private.idl
index b07aed44cd5f5e5cba33be29b6560608f75945ab..5aab5bd5ca32c4ce499fe5ff57856193420ea46f 100644
--- a/chrome/common/extensions/api/webrtc_logging_private.idl
+++ b/chrome/common/extensions/api/webrtc_logging_private.idl
@@ -57,7 +57,8 @@
DOMString securityOrigin,
GenericDoneCallback callback);
- // Uploads the log. Logging must be stopped before this function is called.
+ // Uploads the log and the RTP dumps. Logging must be stopped before this
vrk (LEFT CHROMIUM) 2014/05/02 18:13:48 Nit: maybe clarify, "the RTP dumps, if they exist.
jiayl 2014/05/02 21:22:43 Done.
+ // function is called.
static void upload(long tabId,
DOMString securityOrigin,
UploadDoneCallback callback);
@@ -66,5 +67,22 @@
static void discard(long tabId,
DOMString securityOrigin,
GenericDoneCallback callback);
+
+ // Starts RTP dumping. If it has already been started for this render
+ // process, the call will be ignored.
+ static void startRtpDump(long tabId,
+ DOMString securityOrigin,
+ boolean incoming,
+ boolean outgoing,
+ GenericDoneCallback callback);
+
+ // Stops RTP dumping. After stop has finished, the dumps will be
+ // uploaded with the log if upload is called. Otherwise, the dumps will be
+ // discarded.
+ static void stopRtpDump(long tabId,
+ DOMString securityOrigin,
+ boolean incoming,
+ boolean outgoing,
+ GenericDoneCallback callback);
};
};

Powered by Google App Engine
This is Rietveld 408576698