Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: chrome/browser/media/webrtc_logging_handler_host.h

Issue 267623003: Adds StartRtpDump and StopRtpDump methods to webrtcLoggingPrivate API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_logging_handler_host.h
diff --git a/chrome/browser/media/webrtc_logging_handler_host.h b/chrome/browser/media/webrtc_logging_handler_host.h
index d4605ba6d402f1c3afd5f89de95b76eabdcc468d..e9f36d276ef3753b1faa66f17dcd5da0b133006a 100644
--- a/chrome/browser/media/webrtc_logging_handler_host.h
+++ b/chrome/browser/media/webrtc_logging_handler_host.h
@@ -73,6 +73,18 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter {
upload_log_on_render_close_ = should_upload;
}
+ // Starts dumping the RTP headers for the specified direction. Must be called
+ // on the IO thread.
vrk (LEFT CHROMIUM) 2014/05/02 18:13:48 nit: expand comment to explain the parameters.
jiayl 2014/05/02 21:22:43 Done.
+ void StartRtpDump(bool incoming,
+ bool outgoing,
+ const GenericDoneCallback& callback);
+
+ // Stops dumping the RTP headers for the specified direction. Must be called
+ // on the IO thread.
vrk (LEFT CHROMIUM) 2014/05/02 18:13:48 nit: expand comment to explain the parameters.
jiayl 2014/05/02 21:22:43 Done.
+ void StopRtpDump(bool incoming,
+ bool outgoing,
+ const GenericDoneCallback& callback);
+
private:
// States used for protecting from function calls made at non-allowed points
// in time. For example, StartLogging() is only allowed in CLOSED state.

Powered by Google App Engine
This is Rietveld 408576698