Adds StartRtpDump and StopRtpDump methods to webrtcLoggingPrivate API.

chrome/common/extensions/api/webrtc_logging_private.idl

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.webrtcLoggingPrivate</code> API to control diagnostic
 // WebRTC logging.
 [nodoc] namespace webrtcLoggingPrivate {
   dictionary MetaDataEntry {
     // The meta data entry key.
     DOMString key;
@@ skipping 20 matching lines @@
     // Sets additional custom meta data that will be uploaded along with the
     // log. |metaData| is a dictionary of the metadata (key, value).
     static void setMetaData(long tabId,
                             DOMString securityOrigin,
                             MetaDataEntry[] metaData,
                             GenericDoneCallback callback);
 
     // Starts logging. If logging has already been started for this render
     // process, the call will be ignored. |appSessionId| is the unique session
     // ID which will be added to the log.
     static void start(long tabId,

[Henrik Grunell, 2014/05/05 14:15:09]

I'd like "start, "stop" and "discard" to be renamed to say "startDiagnosticLog"
etc. or such. To be clear what they do. It requires updates in the users of the
API, I'm fine with doing such API change in a follow-up CL.

[jiayl, 2014/05/05 16:26:54]

Ack. https://code.google.com/p/chromium/issues/detail?id=370040

                       DOMString securityOrigin,
                       GenericDoneCallback callback);
 
     // Sets whether the log should be uploaded automatically for the case when
     // the render process goes away (tab is closed or crashes) and stop has not
     // been called before that. If |shouldUpload| is true it will be uploaded,
     // otherwise it will be discarded. The default setting is to discard it.
     static void setUploadOnRenderClose(long tabId,
                                        DOMString securityOrigin,
                                        boolean shouldUpload);
 
     // Stops logging. After stop has finished, either upload() or discard()
     // should be called, otherwise the log will be kept in memory until the
     // render process is closed or logging restarted.
     static void stop(long tabId,
                      DOMString securityOrigin,
                      GenericDoneCallback callback);
 
-    // Uploads the log. Logging must be stopped before this function is called.
+    // Uploads the log and the RTP dumps, if they exist. Logging and RTP dumping
+    // must be stopped before this function is called.
     static void upload(long tabId,
                        DOMString securityOrigin,
                        UploadDoneCallback callback);
 
     // Discards the log. Logging must be stopped before this function is called.
     static void discard(long tabId,
                         DOMString securityOrigin,
                         GenericDoneCallback callback);
+
+    // Starts RTP dumping. If it has already been started for this render
+    // process, the call will be ignored.
+    static void startRtpDump(long tabId,
+                             DOMString securityOrigin,
+                             boolean incoming,
+                             boolean outgoing,
+                             GenericDoneCallback callback);
+
+    // Stops RTP dumping. After stop has finished, the dumps will be
+    // uploaded with the log if upload is called. Otherwise, the dumps will be
+    // discarded.
+    static void stopRtpDump(long tabId,
+                            DOMString securityOrigin,
+                            boolean incoming,

[Henrik Grunell, 2014/05/05 14:15:09]

Is |incoming| and |outgoing| necessary? Maybe simply stop whatever has started?

[jiayl, 2014/05/05 16:26:54]

The existing UI for the GTP allows the user to check/uncheck incoming/outgoing
dump separately. So I think we might need this flexibility.

+                            boolean outgoing,
+                            GenericDoneCallback callback);
   };
 };