Refactor the forPreload flag to mean speculative preload.

third_party/WebKit/Source/platform/loader/fetch/FetchContext.h

Index: third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
diff --git a/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h b/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
index ffc6869eb58647e2242e800f4aa9c16df9579f6a..cecc8c0391541bfa06f9b71ef04d57ad9edf48ac 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
+++ b/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
@@ -124,23 +124,23 @@ class PLATFORM_EXPORT FetchContext
   virtual bool shouldLoadNewResource(Resource::Type) const { return false; }
   // Called when a resource load is first requested, which may not be when the
   // load actually begins.
-  // TODO(toyoshim): Consider to use enum. See https://crbug.com/675883.
+  enum class V8ActivityLoggingPolicy { SuppressLogging, Log };
   virtual void willStartLoadingResource(unsigned long identifier,
                                         ResourceRequest&,
                                         Resource::Type,
                                         const AtomicString& fetchInitiatorName,
-                                        bool forPreload);
+                                        V8ActivityLoggingPolicy);
   virtual void didLoadResource(Resource*);
 
   virtual void addResourceTiming(const ResourceTimingInfo&);
   virtual bool allowImage(bool, const KURL&) const { return false; }
-  // TODO(toyoshim): Consider to use enum. See https://crbug.com/675883.
+  enum class ReportingPolicy { SuppressReporting, Report };

[kinuko, 2017/02/07 08:20:26]

The enum name 'ReportingPolicy' sounds very generic / is not very helpful for
readers to guess what this is about, could we have a comment and/or give it a
bit more specific name?

[yhirano, 2017/02/07 08:34:06]

Having a generic ReportingPolicy would be good. We have one here, one in CSP,
one in MixedContent. Can we merge them (not in this CL)?

[Yoav Weiss, 2017/02/07 09:10:27]

I'd support that. It'd simplify the code, avoiding conversions from one enum to
the next.

   virtual ResourceRequestBlockedReason canRequest(
       Resource::Type,
       const ResourceRequest&,
       const KURL&,
       const ResourceLoaderOptions&,
-      bool forPreload,
+      ReportingPolicy,
       FetchRequest::OriginRestriction) const {
     return ResourceRequestBlockedReason::Other;
   }