Refactor the forPreload flag to mean speculative preload.

third_party/WebKit/Source/platform/loader/fetch/FetchContext.h

Index: third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
diff --git a/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h b/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
index ffc6869eb58647e2242e800f4aa9c16df9579f6a..3858b9b1c20103fb835c304e258287e6c10d7003 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
+++ b/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
@@ -124,23 +124,23 @@ class PLATFORM_EXPORT FetchContext
   virtual bool shouldLoadNewResource(Resource::Type) const { return false; }
   // Called when a resource load is first requested, which may not be when the
   // load actually begins.
-  // TODO(toyoshim): Consider to use enum. See https://crbug.com/675883.
+  enum class LoggingPolicy { SuppressLogging, Log };

[Charlie Harrison, 2017/02/06 19:54:16]

This is much better, but I wonder if we can clarify "Logging" in some way.

It doesn't mean UMA logging, TRACE_EVENT logging, or report logging. If you
don't think it's too specific (will anything else fall in this category?), I'd
just change it to V8ActivityLoggingPolicy or something.

[Yoav Weiss, 2017/02/06 23:15:49]

done

   virtual void willStartLoadingResource(unsigned long identifier,
                                         ResourceRequest&,
                                         Resource::Type,
                                         const AtomicString& fetchInitiatorName,
-                                        bool forPreload);
+                                        LoggingPolicy);
   virtual void didLoadResource(Resource*);
 
   virtual void addResourceTiming(const ResourceTimingInfo&);
   virtual bool allowImage(bool, const KURL&) const { return false; }
-  // TODO(toyoshim): Consider to use enum. See https://crbug.com/675883.
+  enum class ReportingPolicy { SuppressReporting, Report };
   virtual ResourceRequestBlockedReason canRequest(
       Resource::Type,
       const ResourceRequest&,
       const KURL&,
       const ResourceLoaderOptions&,
-      bool forPreload,
+      ReportingPolicy,
       FetchRequest::OriginRestriction) const {
     return ResourceRequestBlockedReason::Other;
   }