Refactor the forPreload flag to mean speculative preload.

third_party/WebKit/Source/core/loader/LinkLoader.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 321 matching lines @@
   if (crossOrigin != CrossOriginAttributeNotSet) {
     linkRequest.setCrossOriginAccessControl(document.getSecurityOrigin(),
                                             crossOrigin);
   }
   Settings* settings = document.settings();
   if (settings && settings->getLogPreload()) {
     document.addConsoleMessage(ConsoleMessage::create(
         OtherMessageSource, VerboseMessageLevel,
         String("Preload triggered for " + href.host() + href.path())));
   }
-  linkRequest.setForPreload(true, monotonicallyIncreasingTime());

[Charlie Harrison, 2017/02/05 18:39:11]

I think this will affect metrics, but I think it is correct and those metrics
should only be for speculative preloads.

[Yoav Weiss, 2017/02/06 09:58:35]

Yeah, I agree

   linkRequest.setLinkPreload(true);
   return document.loader()->startPreload(resourceType.value(), linkRequest);
 }
 
 static Resource* prefetchIfNeeded(Document& document,
                                   const KURL& href,
                                   const LinkRelAttribute& relAttribute,
                                   CrossOriginAttributeValue crossOrigin,
                                   ReferrerPolicy referrerPolicy) {
   if (relAttribute.isLinkPrefetch() && href.isValid() && document.frame()) {
@@ skipping 136 matching lines @@
 
 DEFINE_TRACE(LinkLoader) {
   visitor->trace(m_client);
   visitor->trace(m_prerender);
   visitor->trace(m_linkPreloadResourceClient);
   ResourceOwner<Resource, ResourceClient>::trace(visitor);
   PrerenderClient::trace(visitor);
 }
 
 }  // namespace blink