net/url_request/url_request_job.cc - Issue 2676033002: Give URLRequestJob::GetResponseCode a better default implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job.cc

Issue 2676033002: Give URLRequestJob::GetResponseCode a better default implementation. (Closed)

Patch Set: Add headers Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_job.cc

diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc

index cdf60f80fdad3d001ad68fd39eaae9af4b98e1d2..464e920fbef71ed6536dc0b89fb0efed08f68041 100644

--- a/net/url_request/url_request_job.cc

+++ b/net/url_request/url_request_job.cc

@@ -334,7 +334,10 @@ bool URLRequestJob::GetMimeType(std::string* mime_type) const {

}

int URLRequestJob::GetResponseCode() const {

- return -1;

+ HttpResponseHeaders* headers = request_->response_headers();

+ if (!headers)

+ return -1;

+ return headers->response_code();

}

HostPortPair URLRequestJob::GetSocketAddress() const {