Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2676023002: Update status for fasta unit tests in --use-sdk case (Closed)

Created:
3 years, 10 months ago by Bill Hesse
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider, ahe
CC:
reviews_dartlang.org, ahe, Paul Berry, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for fasta unit tests in --use-sdk case BUG=https://github.com/dart-lang/sdk/issues/28629 R=ahe@google.com, fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/35d9f57f0e9f982be15577c5b478871bb689f66c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add package build status fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/pkg.status View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/pkgbuild.status View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
We could put in more flags, to distinguish between the case when patched_sdk is present ...
3 years, 10 months ago (2017-02-03 18:32:20 UTC) #1
Florian Schneider
lgtm
3 years, 10 months ago (2017-02-03 18:43:16 UTC) #2
ahe
not lgtm https://codereview.chromium.org/2676023002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/2676023002/diff/1/pkg/pkg.status#newcode61 pkg/pkg.status:61: front_end/test/fasta/outline_test: Pass, Fail # Issue 28629 Just ...
3 years, 10 months ago (2017-02-03 18:50:13 UTC) #4
ahe
LGTM if you change it to "skip" instead. Fail won't work as they might run ...
3 years, 10 months ago (2017-02-03 19:22:38 UTC) #5
Bill Hesse
3 years, 10 months ago (2017-02-03 19:31:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
35d9f57f0e9f982be15577c5b478871bb689f66c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698