chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 2675983003: views::Separator cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 2675983003: views::Separator cleanup. (Closed)

Patch Set: fix another callsite Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.cc ('k') | chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc » ('j') | ui/views/controls/separator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index 4d94178ce8777be45eea975a5015ca317932d3a6..a4aebe63476e3941122ef7551a080b3732954e65 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -257,8 +257,8 @@ void ExtensionInstallDialogView::InitView() {

if (prompt_->ShouldShowPermissions()) {

layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);

layout->StartRow(0, column_set_id);

- layout->AddView(new views::Separator(views::Separator::HORIZONTAL), 3, 1,

- views::GridLayout::FILL, views::GridLayout::FILL);

+ layout->AddView(new views::Separator(), 3, 1, views::GridLayout::FILL,

+ views::GridLayout::FILL);

}

const int content_width =