views::Separator cleanup.

ash/common/system/tray/tray_details_view.cc

Index: ash/common/system/tray/tray_details_view.cc
diff --git a/ash/common/system/tray/tray_details_view.cc b/ash/common/system/tray/tray_details_view.cc
index 08d71fe689fbba17867e812a61904dddd47d01c7..f03f9b4b389f0c2d063bd8ef1055f48a06f3daaa 100644
--- a/ash/common/system/tray/tray_details_view.cc
+++ b/ash/common/system/tray/tray_details_view.cc
@@ -133,7 +133,6 @@ class ScrollContentsView : public views::View {
   }
 
  private:
-  const SkColor kSeparatorColor = SkColorSetA(SK_ColorBLACK, 0x1F);
   const int kShadowOffsetY = 2;
   const int kShadowBlur = 2;
   // TODO(fukino): Remove this constant once we stop maintaining pre-MD design.
@@ -219,7 +218,7 @@ class ScrollContentsView : public views::View {
     cc::PaintFlags paint;
     gfx::ShadowValues shadow;
     shadow.emplace_back(gfx::Vector2d(0, kShadowOffsetY), kShadowBlur,
-                        kSeparatorColor);
+                        kMenuSeparatorColor);
     paint.setLooper(gfx::CreateShadowDrawLooperCorrectBlur(shadow));
     paint.setAntiAlias(true);
     canvas->ClipRect(shadowed_area, SkClipOp::kDifference);
@@ -345,10 +344,9 @@ void TrayDetailsView::CreateTitleRow(int string_id) {
     AddChildViewAt(tri_view_, 0);
     views::Separator* separator =
         new views::Separator(views::Separator::HORIZONTAL);
-    separator->SetColor(kHorizontalSeparatorColor);
-    separator->SetPreferredSize(kSeparatorWidth);
+    separator->SetColor(kMenuSeparatorColor);
     separator->SetBorder(views::CreateEmptyBorder(
-        kTitleRowProgressBarHeight - kSeparatorWidth, 0, 0, 0));

[tdanderson, 2017/02/06 21:19:06]

There are two other instances of |kSeparatorWidth| in this class that you
probably want to replace with the new views version too.

[Evan Stade, 2017/02/06 21:39:17]

I intentionally did not update the uses that are not views::Separator related. I
did add a test to make sure we could use these constants interchangeably.

+        kTitleRowProgressBarHeight - views::Separator::kThickness, 0, 0, 0));
     AddChildViewAt(separator, kTitleRowSeparatorIndex);
   } else {
     title_row_ = new SpecialPopupRow();