Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 2675983003: views::Separator cleanup. (Closed)
Patch Set: revert test change Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index ec12345a5ed4b922a61fdbbec6a18ea3f3130757..0494117c40f2437e050a6d93b7a97c3512408601 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -701,7 +701,7 @@ class TitleCard : public views::View {
layout->StartRowWithPadding(1, 0, 0, kVerticalSpacing);
layout->AddView(title_card);
layout->StartRowWithPadding(1, 1, 0, kVerticalSpacing);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
layout->StartRow(1, 1);
layout->AddView(view);
@@ -1294,7 +1294,7 @@ void ProfileChooserView::PopulateCompleteProfileChooserView(
layout->StartRow(1, 0);
layout->AddView(sync_error_view);
layout->StartRow(0, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
}
if (!current_profile_view) {
@@ -1309,7 +1309,7 @@ void ProfileChooserView::PopulateCompleteProfileChooserView(
if (!IsProfileChooser(view_mode_)) {
DCHECK(current_profile_accounts);
layout->StartRow(0, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
layout->StartRow(1, 0);
layout->AddView(current_profile_accounts);
}
@@ -1317,14 +1317,14 @@ void ProfileChooserView::PopulateCompleteProfileChooserView(
if (browser_->profile()->IsSupervised()) {
if (!switches::IsMaterialDesignUserMenu()) {
layout->StartRow(0, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
}
layout->StartRow(1, 0);
layout->AddView(CreateSupervisedUserDisclaimerView());
}
layout->StartRow(0, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
if (option_buttons_view) {
layout->StartRow(0, 0);
@@ -1886,7 +1886,7 @@ views::View* ProfileChooserView::CreateOtherProfilesView(
open_other_profile_indexes_map_[button] = index;
layout->StartRow(1, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
layout->StartRow(1, 0);
layout->AddView(button);
}
@@ -1961,7 +1961,7 @@ views::View* ProfileChooserView::CreateOptionsView(bool display_lock,
if (!switches::IsMaterialDesignUserMenu() && ShouldShowGoIncognito()) {
layout->StartRow(1, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
go_incognito_button_ = new BackgroundColorHoverButton(
@@ -1975,7 +1975,7 @@ views::View* ProfileChooserView::CreateOptionsView(bool display_lock,
if (display_lock) {
if (!switches::IsMaterialDesignUserMenu()) {
layout->StartRow(1, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
}
lock_button_ = new BackgroundColorHoverButton(
@@ -2332,7 +2332,7 @@ views::View* ProfileChooserView::CreateSwitchUserView() {
// Adds "Add person" button.
layout->StartRowWithPadding(1, 0, 0, views::kUnrelatedControlVerticalSpacing);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
const int kIconSize = 24;
add_person_button_ = new BackgroundColorHoverButton(
@@ -2344,7 +2344,7 @@ views::View* ProfileChooserView::CreateSwitchUserView() {
// Adds "Disconnect your Google Account" button.
layout->StartRow(1, 0);
- layout->AddView(new views::Separator(views::Separator::HORIZONTAL));
+ layout->AddView(new views::Separator());
disconnect_button_ = new BackgroundColorHoverButton(
this, l10n_util::GetStringUTF16(IDS_PROFILES_DISCONNECT_BUTTON),
« no previous file with comments | « chrome/browser/ui/views/find_bar_view.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698