Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html

Issue 2675973003: Convert Oscillator sweep tests to testharness (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
index 544e85964162ce40598c8b0d4640e76fa509558a..f32e3cac9d3909710c3a6753dc228402f8340573 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
@@ -2,21 +2,35 @@
<html>
<head>
<title>Test Oscillator Node: triangle</title>
+ <script src="../../resources/testharness.js"></script>
+ <script src="../../resources/testharnessreport.js"></script>
+ <script src="../resources/audit-util.js"></script>
+ <script src="../resources/audit.js"></script>
<script src="../resources/buffer-loader.js"></script>
- <script src="../../resources/js-test.js"></script>
<script src="../resources/oscillator-testing.js"></script>
</head>
<body>
<script>
- description("Test Triangle Oscillator with Exponential Sweep");
+ let audit = Audit.createTaskRunner();
+ let tester = OscillatorTestingUtils;
- // Thresholds for verifying the test passes. The thresholds are experimentally determined.
-
- var tester = OscillatorTestingUtils;
- tester.setThresholds({snr: 80.50, maxDiff: 5.71, diffCount: 16982});
- tester.runTest("triangle");
- successfullyParsed = true;
+ audit.define("test", (task, should) => {
+ let context = new OfflineAudioContext(1, tester.sampleRate *
+ tester.lengthInSeconds, tester.sampleRate);
+
+ // Thresholds for verifying the test passes. The thresholds are
+ // experimentally determined.
+ tester.setThresholds({
+ snr: 80.50,
+ maxDiff: 5.71,
+ diffCount: 16982
+ });
+ tester.runTest(context, "triangle",
+ "Triangle Oscillator with Exponential Sweep ", task, should);
+ });
+
+ audit.run();
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698