third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html - Issue 2675973003: Convert Oscillator sweep tests to testharness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html

Issue 2675973003: Convert Oscillator sweep tests to testharness (Closed)

Patch Set: Address review comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html

index baa4eca96521dfd0bf2fb2a8375eb65f9c045d8a..ec4383b6fba515c0ae5aebd72cde10d7ac49301f 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html

@@ -2,22 +2,34 @@

<html>

<head>

<title>Test Oscillator Node: square</title>

+ <script src="../../resources/testharness.js"></script>

+ <script src="../../resources/testharnessreport.js"></script>

+ <script src="../resources/audit-util.js"></script>

+ <script src="../resources/audit.js"></script>

- <script src="../../resources/js-test.js"></script>

</head>

<body>

- description("Test Square Oscillator with Exponential Sweep");

+ let audit = Audit.createTaskRunner();

+ let tester = OscillatorTestingUtils;

- // Thresholds for verifying the test passes. The thresholds are experimentally determined.

+ audit.define("test", (task, should) => {

+ let context = new OfflineAudioContext(1, tester.sampleRate *

+ tester.lengthInSeconds, tester.sampleRate);

- var tester = OscillatorTestingUtils;

- // The thresholds are experimentally determined.

- tester.setThresholds({snr: 81.57, maxDiff: 7.26, diffCount: 18260});

- tester.runTest("square");

- successfullyParsed = true;

+ // The thresholds are experimentally determined.

+ tester.setThresholds({

+ snr: 81.57,

+ maxDiff: 7.26,

+ diffCount: 18260

+ });

+ tester.runTest(context, "square",

+ "Square Oscillator with Exponential Sweep", task, should);

+ });

+ audit.run();

</script>

</body>

</html>