third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html - Issue 2675973003: Convert Oscillator sweep tests to testharness

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html

Issue 2675973003: Convert Oscillator sweep tests to testharness (Closed)

Patch Set: Move audit calls outside of tester Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr-expected.txt » ('j') | third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Test Oscillator Node: custom</title>	4 <title>Test Oscillator Node: custom</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <script src="../resources/audit-util.js"></script>

	8 <script src="../resources/audit.js"></script>

5 <script src="../resources/buffer-loader.js"></script>	9 <script src="../resources/buffer-loader.js"></script>

6 <script src="../../resources/js-test.js"></script>

7 <script src="../resources/oscillator-testing.js"></script>	10 <script src="../resources/oscillator-testing.js"></script>

8 </head>	11 </head>

9	12

10 <body>	13 <body>

11 <script>	14 <script>

12 description("Test Custom Oscillator with Exponential Sweep");	15 let audit = Audit.createTaskRunner();

13

14 var tester = OscillatorTestingUtils;	16 var tester = OscillatorTestingUtils;
	hongchan 2017/02/07 18:18:53 var => let. You changed this in other tests. So l var => let. You changed this in other tests. So let's be consistent.
15	17

16 // The thresholds are experimentally determined.	18 audit.define("test", (task, should) => {

17 tester.setThresholds({snr: 80.21, maxDiff: 4.88, diffCount: 15016});	19 let context = new OfflineAudioContext(1, tester.sampleRate *

18 tester.runTest("custom");	20 tester.lengthInSeconds, tester.sampleRate);

19 successfullyParsed = true;	21

	22 // The thresholds are experimentally determined.

	23 tester.setThresholds({

	24 snr: 80.21,

	25 maxDiff: 4.88,

	26 diffCount: 15016

	27 });

	28 tester.runTest(context, "custom",

	29 "Custom Oscillator with Exponential Sweep", task, should);

	30 });

	31

	32 audit.run();

20 </script>	33 </script>

21 </body>	34 </body>

22 </html>	35 </html>

OLD	NEW