Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: pkg/analyzer/lib/src/generated/error_verifier.dart

Issue 2675963004: fix #28630, instance method tear-offs are treated as strict arrows (Closed)
Patch Set: fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/error_verifier.dart
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index 742a0a168d9145f5df570c80d1f73ea4375f5e35..32469f1dc73e1f1f9db08cb060319771cb673173 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -33,7 +33,7 @@ import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/utilities_dart.dart';
import 'package:analyzer/src/task/dart.dart';
import 'package:analyzer/src/task/strong/checker.dart' as checker
- show isKnownFunction;
+ show hasStrictArrow;
/**
* A visitor used to traverse an AST structure looking for additional errors and
@@ -6244,7 +6244,7 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
bool _expressionIsAssignableAtType(Expression expression,
DartType actualStaticType, DartType expectedStaticType) {
- bool concrete = _options.strongMode && checker.isKnownFunction(expression);
+ bool concrete = _options.strongMode && checker.hasStrictArrow(expression);
if (concrete && actualStaticType is FunctionType) {
actualStaticType =
_typeSystem.functionTypeToConcreteType(actualStaticType);
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/strong/checker.dart » ('j') | pkg/analyzer/lib/src/task/strong/checker.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698