Refactor menu controller to isolate aura dependency.

ui/views/controls/menu/menu_message_loop.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_VIEWS_CONTROLS_MENU_MENU_MESSAGE_LOOP_H_
+#define UI_VIEWS_CONTROLS_MENU_MENU_MESSAGE_LOOP_H_
+
+#include "ui/gfx/native_widget_types.h"
+
+namespace gfx {
+class Point;
+}
+
+namespace ui {
+class LocatedEvent;
+}
+
+namespace views {
+
+class MenuController;
+class Widget;
+
+// Interface used by MenuController to run a nested message loop while
+// showing a menu, allowing for platform specific implementations.
+class MenuMessageLoop {
+ public:
+  virtual ~MenuMessageLoop() {}
+
+  // Create a platform specific instance.
+  static MenuMessageLoop* Create();
+
+  // Runs the platform specific bits of the message loop. If |nested_menu| is
+  // true we're being asked to run a menu from within a menu (eg a context
+  // menu).
+  virtual void Run(MenuController*, Widget* owner, bool nested_menu) = 0;
+
+  virtual bool ShouldQuitNow() const = 0;

[sky, 2014/05/15 16:07:32]

Add description for functions.

[Andre, 2014/05/15 18:45:59]

Done.

+  virtual void QuitNow() = 0;
+  virtual void RepostEventToWindow(const ui::LocatedEvent& event,
+                                   gfx::NativeWindow window,
+                                   gfx::Point screen_loc) = 0;

[sky, 2014/05/15 16:07:32]

const gfx::Point&

[Andre, 2014/05/15 18:45:59]

Done.

+
+  // How deep we are in nested message loops. This should be at most 2 (when
+  // showing a context menu from a menu).
+  virtual int message_loop_depth() const = 0;

[sky, 2014/05/15 16:07:32]

Don't use unix_hacker_style for virtual methods (see style guide). Also, is
there really a reason to move this to MenuMessageLoop? It appears to be the same
between the two implementations and can just as easily be tracked in
MenuController.

[Andre, 2014/05/15 18:45:59]

Done.
Renamed the  method to GetNestedDepth().
This was moved here because we can only clear owner_ after we exited all nested
loops, in MenuMessageLoopAura:Run,
  message_loop_depth_--;
  if (message_loop_depth_ == 0)
    owner_ = NULL;

[sky, 2014/05/15 19:33:01]

Do you still need it once you get rid of SetOwner?

[Andre, 2014/05/15 20:57:12]

No longer needed with the addition of ClearOwner.
Moved it back to MenuController.

+};
+
+}  // namespace views
+
+#endif  // UI_VIEWS_CONTROLS_MENU_MENU_MESSAGE_LOOP_H_